-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23524/#review47941
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/23524/#comment84180>

    remove synchronized



core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/23524/#comment84181>

    static final



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/23524/#comment84182>

    else if JobsConcurrencyService.isHAMode



core/src/main/java/org/apache/oozie/util/LogUtils.java
<https://reviews.apache.org/r/23524/#comment84185>

    avoid this new XLog.Info()
    
    Have a new method that does clear and set directly on XLog.Info.get()


- Rohini Palaniswamy


On July 16, 2014, 8:09 p.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23524/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 8:09 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1933
>     https://issues.apache.org/jira/browse/OOZIE-1933
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 
> 6c075ab 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5349b33 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 5b30fc0 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 723ac36 
>   core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 
> ffb25e7 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 
> 438f2c2 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 205bcd1 
>   core/src/test/java/org/apache/oozie/test/XTestCase.java 6bf0a8f 
> 
> Diff: https://reviews.apache.org/r/23524/diff/
> 
> 
> Testing
> -------
> 
> added new tests and checked existing ones pass
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>

Reply via email to