> On July 15, 2014, 11:37 p.m., Purshotam Shah wrote:
> > It that possible to add a new method in logutil which take prefix( jobid,
> > name, actionID) and log message and logs it.
> >
> > I see that, to log a singe statement we are doing below statement. Not
> > sure, but I guess we can do it in single line, by passing prefix(
> > jobid,name,actionID) and log message.
> >
> > synchronized (workerLog) {
> > setLogPrefix(workerLog, event);
> > LOG.debug("Processing event : {0}", event);
> > LogUtils.clearLogPrefix();
> > }
removed the synchronized. however clearing is required as the logs carry a lot
of occurrences where the prefix points to the earlier jobid/actionid and the
job/action it is actually working on is now different.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23524/#review47837
-----------------------------------------------------------
On July 15, 2014, 9:11 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23524/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 9:11 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1933
> https://issues.apache.org/jira/browse/OOZIE-1933
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/EventHandlerService.java
> 6c075ab
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5349b33
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 5b30fc0
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
> core/src/main/java/org/apache/oozie/util/LogUtils.java 723ac36
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java
> ffb25e7
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
> 438f2c2
> core/src/test/java/org/apache/oozie/sla/TestSLAService.java 205bcd1
> core/src/test/java/org/apache/oozie/test/XTestCase.java e739ec3
>
> Diff: https://reviews.apache.org/r/23524/diff/
>
>
> Testing
> -------
>
> added new tests and checked existing ones pass
>
>
> Thanks,
>
> Mona Chitnis
>
>
