[ 
https://issues.apache.org/jira/browse/OOZIE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319410#comment-14319410
 ] 

Robert Kanter commented on OOZIE-2129:
--------------------------------------

RB might require the {{--full-index}} option when doing {{git diff}}.  Our 
internal RB does.

I'm not surprised the hadoop-3 profile isn't working; I don't think anyone's 
tried running it for a while.  Copy-pasting the same code has hadoop-2 is fine 
for now.

I took a quick look; a few comments:
# Why do we get rid of {{gar.setStartRange(startTime, 
System.currentTimeMillis());}}?  IIRC, I put this in to help lower the cost on 
YARN's side of looking up apps by tags.  We don't have to look any earlier than 
{{startTime}}
# I'm not sure we should add support for this to the Java action.  While you 
can run MR jobs from it, and many users do, we've typically avoided adding 
MR-specific features to it to encourage users to use the MR action.  The Java 
action's primary purpose is to run Java programs
# I'm not sure if this is a problem, but if the user upgrades to a version of 
Oozie with this patch, any actions running during the upgrade won't be able to 
properly use the tags, right?  Even if that's a problem, it's not likely to 
occur.
# In {{LauncherMapper}}, don't replace the {{java.io}} import with {{import 
java.io.*}}; we don't typically use {{*}} for imports
# I'm not sure I understand how the {{propagation-conf.xml}} is used; aren't 
all of the necessary configs appropriately set in the launcher and action confs 
already?

> Duplicate child jobs per instance
> ---------------------------------
>
>                 Key: OOZIE-2129
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2129
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Jaydeep Vishwakarma
>         Attachments: OOZIE-2129-v0.patch, OOZIE-2129-v1.patch
>
>
> OOZIE-1722 ensures that child job is killed at launcher restart. But this 
> doesn't work for java actions as the tag is not passed to the child job.
> In case of coord action rerun, new workflow is created and hence new tag. So, 
> it doesn't ensure old child job is killed at launcher start



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to