----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36123/#review94893 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java (line 137) <https://reviews.apache.org/r/36123/#comment149576> should be >= 400 core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java (line 53) <https://reviews.apache.org/r/36123/#comment149570> sends notification along with relevant arguments to applicable end point. core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java (line 61) <https://reviews.apache.org/r/36123/#comment149571> Would like constant and the config name to include the units (for ex. if the units are in milliseconds), would prefer the constant to be named CALLBACK_ACTION_HTTP_SOCKET_TIMEOUT_MS and the name to be oozie.action.callback.http.socket.timeout.ms core/src/test/java/org/apache/oozie/action/callback/TestCallBackActionExecutor.java (line 22) <https://reviews.apache.org/r/36123/#comment149572> You can't have dependency on com.sun.* they are typically private and shouldn't be used. docs/src/site/twiki/DG_CallbackActionExtension.twiki (line 14) <https://reviews.apache.org/r/36123/#comment149573> It has support for docs/src/site/twiki/DG_CallbackActionExtension.twiki (line 15) <https://reviews.apache.org/r/36123/#comment149574> Replace "An callback action" with "Callback action" docs/src/site/twiki/DG_CallbackActionExtension.twiki (line 56) <https://reviews.apache.org/r/36123/#comment149575> Default values for callback action properties are configured in oozie-default.xml and can be overriden through oozie-site.xml - Srikanth Sundarrajan On Aug. 6, 2015, 9:13 a.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36123/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 9:13 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2259 > https://issues.apache.org/jira/browse/OOZIE-2259 > > > Repository: oozie-git > > > Description > ------- > > Adding callback as an action, It have support for HTTP and JMS server. Not > covering Excecutor level queue, I will create a separate jira for it. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java c381432 > client/src/main/resources/callback-action-0.1.xsd PRE-CREATION > > core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/callback/JMSNotification.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/CallBackActionService.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 4dc127e > > core/src/test/java/org/apache/oozie/action/callback/TestCallBackActionExecutor.java > PRE-CREATION > docs/src/site/twiki/DG_CallbackActionExtension.twiki PRE-CREATION > docs/src/site/twiki/DG_CommandLineTool.twiki 9494b22 > docs/src/site/twiki/index.twiki 8591530 > > Diff: https://reviews.apache.org/r/36123/diff/ > > > Testing > ------- > > Done, > Will add more test cases. > > > Thanks, > > Jaydeep Vishwakarma > >
