> On Nov. 25, 2015, 9:47 p.m., Robert Kanter wrote: > > core/src/test/java/org/apache/oozie/action/callback/TestCallbackActionExecutor.java, > > line 133 > > <https://reviews.apache.org/r/36123/diff/6/?file=1124153#file1124153line133> > > > > Perhaps we should use ``(freeHTTPPort + 1)`` for this?
I understood your concern. Even it is possible that the freeHTTPPort + 1 has been occupied by some server. I will use findFreePort() to ensure the unused port. > On Nov. 25, 2015, 9:47 p.m., Robert Kanter wrote: > > core/src/test/java/org/apache/oozie/action/callback/TestCallbackActionExecutor.java, > > line 172 > > <https://reviews.apache.org/r/36123/diff/6/?file=1124153#file1124153line172> > > > > Perhaps we should use ``(freeJMSPort + 1)`` for this? Same here , I will use findFreePort() to ensure the unused port. - Jaydeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36123/#review108065 ----------------------------------------------------------- On Nov. 26, 2015, 7:43 a.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36123/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 7:43 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2259 > https://issues.apache.org/jira/browse/OOZIE-2259 > > > Repository: oozie-git > > > Description > ------- > > Adding callback as an action, It have support for HTTP and JMS server. Not > covering Excecutor level queue, I will create a separate jira for it. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 48bac7d > client/src/main/resources/callback-action-0.1.xsd PRE-CREATION > > core/src/main/java/org/apache/oozie/action/callback/CallbackActionExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/callback/JMSNotification.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/CallbackActionService.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 0a7e250 > > core/src/test/java/org/apache/oozie/action/callback/TestCallbackActionExecutor.java > PRE-CREATION > docs/src/site/twiki/DG_CallbackActionExtension.twiki PRE-CREATION > docs/src/site/twiki/DG_CommandLineTool.twiki 1823247 > docs/src/site/twiki/index.twiki 8591530 > > Diff: https://reviews.apache.org/r/36123/diff/ > > > Testing > ------- > > Done, > Will add more test cases. > > > Thanks, > > Jaydeep Vishwakarma > >
