> On Jan. 18, 2016, 5:31 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/DG_CallbackActionExtension.twiki, lines 64-66 > > <https://reviews.apache.org/r/36123/diff/8/?file=1148602#file1148602line64> > > > > Currently it only seems to be contents of body of MapMessage. In > > future, if support for Message properties has to be added how is that > > supposed to be done? Or if different type of Message - says TextMessage has > > to be supported. > > > > In case of http get, it seems to be query params and with post it seems > > to be form params (application/x-www-form-urlencoded). What if > > application/octet-stream needs to be supported in the future? > > > > I think we need to define and document all this clearly and also make > > sure it is not difficult to enhance in future. As I see it, the current > > form of definition makes it hard to support additional features of HTTP or > > JMS in future without hacking around how arguments are defined as we are > > assuming now by default there is only one way of doing it. > > Jaydeep Vishwakarma wrote: > I agree, I will detail out all the details in doc. > I have created a jira OOZIE-2403 for custom method. I will take care the > future enchancement part there. > > Rohini Palaniswamy wrote: > I am not asking about adding those future enhancements. The current xsd > and argument/data passing interface is not clean enough to extend in future. > That needs to be fixed here taking future enhancements into account. Even > current usage is not even clear from documentation. I had to look into code > to understand what kind of data and parameters are constructed for all > methods and what needs to be actually passed in the arg section by the user > for them to be used.
One more thing I missed mentioning is HTTP headers (to specify content type, etc). Basically what I am asking is to go back and revisit all options/features associated with HTTP and JMS and come up with a generic way for user to easily and intuitively represent them in xml without confusion. Code/implementation can be easily changed anytime later but not the interface we expose to the user. We can have schema revisioning to support more enhancements. But with current schema, it will be a lot of behavior change next time if something has to be added which will not be good. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36123/#review114940 ----------------------------------------------------------- On Jan. 18, 2016, 1:28 p.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36123/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 1:28 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2259 > https://issues.apache.org/jira/browse/OOZIE-2259 > > > Repository: oozie-git > > > Description > ------- > > Adding callback as an action, It have support for HTTP and JMS server. Not > covering Excecutor level queue, I will create a separate jira for it. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 48bac7d > client/src/main/resources/callback-action-0.1.xsd PRE-CREATION > core/src/main/java/org/apache/oozie/action/callback/CallBack.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/action/callback/CallbackActionExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/callback/HTTPCallBack.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/callback/JMSCallBack.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/callback/JMSNotification.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/CallbackActionService.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 0a7e250 > > core/src/test/java/org/apache/oozie/action/callback/TestCallbackActionExecutor.java > PRE-CREATION > docs/src/site/twiki/DG_CallbackActionExtension.twiki PRE-CREATION > docs/src/site/twiki/DG_CommandLineTool.twiki 1823247 > docs/src/site/twiki/index.twiki 8591530 > > Diff: https://reviews.apache.org/r/36123/diff/ > > > Testing > ------- > > Done, > Will add more test cases. > > > Thanks, > > Jaydeep Vishwakarma > >
