----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51029/#review163016 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java (line 287) <https://reviews.apache.org/r/51029/#comment234388> can we just change coord:endOfMonthsRange to coord:absoluteRange. In that case, we can avoid extra function and configuration. core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java (line 300) <https://reviews.apache.org/r/51029/#comment234389> Can move them to different function like resolveInstanceRangeEndOfWeek..... resolveInstanceRange function is getting longer and longer. You should be able to reuse a lot of code. core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java (line 749) <https://reviews.apache.org/r/51029/#comment234390> This for coord timeout. We always consider 30 days for a month. If a job is submitted in Feb, then it will have 28 days for as timeout, and if the same job is submitted in Jan, it will have 31 days as timeout, which will be confusing. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java (line 750) <https://reviews.apache.org/r/51029/#comment234391> Can we also have test case for dataset frequency coord:endOfWeeks. Most of the people will use coord:endOfWeeks for datasets. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 408) <https://reviews.apache.org/r/51029/#comment234392> Should be --+++++ 4.4.2.3. The coord:endOfWeeks(int n) EL function docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 421) <https://reviews.apache.org/r/51029/#comment234393> Similar to endofMonths and endOfDays, coord:endOfWeeks example should have dataset frequency = coord:endOfWeeks. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 473) <https://reviews.apache.org/r/51029/#comment234394> ---++++ 4.4.3. Cron syntax in coordinator frequency docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 2290) <https://reviews.apache.org/r/51029/#comment234395> You can point it to 4.4.2.2. The coord:endOfMonths(int n) EL function docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 2304) <https://reviews.apache.org/r/51029/#comment234397> frequency="${coord:months(1)}" should be daily. You want to run daily and process incremental data starting for the month. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 2355) <https://reviews.apache.org/r/51029/#comment234398> point to el function doc docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 2475) <https://reviews.apache.org/r/51029/#comment234401> frequency="${coord:days(1)}, hourly - Purshotam Shah On Jan. 24, 2017, 10:49 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51029/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 10:49 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2630 > https://issues.apache.org/jira/browse/OOZIE-2630 > > > Repository: oozie-git > > > Description > ------- > > Oozie Coordinator EL Functions to get first day of the week/month > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 0af7edc > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 969336d > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa > core/src/main/java/org/apache/oozie/coord/TimeUnit.java 5b37639 > core/src/main/java/org/apache/oozie/util/DateUtils.java 3caf0a2 > core/src/main/resources/oozie-default.xml ad10386 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 7062e69 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 29e7ca1 > core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java be60133 > core/src/test/resources/coord-dataset-endOfDays.xml PRE-CREATION > core/src/test/resources/coord-dataset-endOfMonths.xml PRE-CREATION > core/src/test/resources/coord-dataset-endOfWeeks.xml PRE-CREATION > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki e3ac514 > > Diff: https://reviews.apache.org/r/51029/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Satish Saley > >
