> On Jan. 25, 2017, 2:14 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java, > > line 749 > > <https://reviews.apache.org/r/51029/diff/5/?file=1613874#file1613874line749> > > > > This for coord timeout. We always consider 30 days for a month. If a > > job is submitted in Feb, then it will have 28 days for as timeout, and if > > the same job is submitted in Jan, it will have 31 days as timeout, which > > will be confusing.
I thought the same earlier, but later after looking at Rohini's comment https://reviews.apache.org/r/15893/#comment57211 I made the change. I will revert it back. > On Jan. 25, 2017, 2:14 p.m., Purshotam Shah wrote: > > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki, line 408 > > <https://reviews.apache.org/r/51029/diff/5/?file=1613885#file1613885line408> > > > > Should be --+++++ 4.4.2.3. The coord:endOfWeeks(int n) EL function It should be separate point 4.4.3. 4.4.2 is for month functions - The coord:months(int n) and coord:endOfMonths(int n) EL functions > On Jan. 25, 2017, 2:14 p.m., Purshotam Shah wrote: > > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki, line 2290 > > <https://reviews.apache.org/r/51029/diff/5/?file=1613885#file1613885line2290> > > > > You can point it to 4.4.2.2. The coord:endOfMonths(int n) EL function The coord:endOfMonths(int n) EL function in 4.4.2.2 is for mentioning the freqency of the coordinator. Here we are documenting the EL function for dataset - 6.6.9. coord:endOfMonths(int n) EL Function for Synchronous Datasets - Satish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51029/#review163016 ----------------------------------------------------------- On Jan. 24, 2017, 2:49 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51029/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:49 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2630 > https://issues.apache.org/jira/browse/OOZIE-2630 > > > Repository: oozie-git > > > Description > ------- > > Oozie Coordinator EL Functions to get first day of the week/month > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 0af7edc > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 969336d > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa > core/src/main/java/org/apache/oozie/coord/TimeUnit.java 5b37639 > core/src/main/java/org/apache/oozie/util/DateUtils.java 3caf0a2 > core/src/main/resources/oozie-default.xml ad10386 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 7062e69 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 29e7ca1 > core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java be60133 > core/src/test/resources/coord-dataset-endOfDays.xml PRE-CREATION > core/src/test/resources/coord-dataset-endOfMonths.xml PRE-CREATION > core/src/test/resources/coord-dataset-endOfWeeks.xml PRE-CREATION > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki e3ac514 > > Diff: https://reviews.apache.org/r/51029/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Satish Saley > >
