[ 
https://issues.apache.org/jira/browse/OOZIE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129360#comment-16129360
 ] 

Robert Kanter commented on OOZIE-2687:
--------------------------------------

I left some specific feedback on RB.  Here's some more general comments:
- If we do these major non-forwards compatible changes to the schemas, perhaps 
it would be a good idea to jump all schema versions to 1.0?  Or at least a 
common 0.x (e.g. 0.10)?  From looking at the patch, we have hive 0.7, hive2 
0.3, oozie-common 0.1, workflow 0.6, shell 0.4, etc.  It's all over the place 
and users will have a hard time keeping track of what versions to put to use 
all of the new features.  
- Another question to consider: should we deprecate the older schemas?  We 
could then remove them in Oozie 6.
- We currently use {{<xs:sequence>}} for most things in the schema.  This means 
that it all has to be in the "correct" order.  Should we think about changing 
that to allow any order?  My concern would be if we're making any assumptions 
about the order when parsing things.  Changing this also makes things more 
complicated, so we might be best off leaving it for now.

> Create XML schema for launcher configurations
> ---------------------------------------------
>
>                 Key: OOZIE-2687
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2687
>             Project: Oozie
>          Issue Type: Sub-task
>    Affects Versions: 5.0.0
>            Reporter: Peter Cseh
>            Assignee: Attila Sasvari
>            Priority: Critical
>         Attachments: OOZIE-2687-001.patch, OOZIE-2687-002.patch
>
>
> It was possible to manipulate the MapperLauncher's environment through 
> properties like:
> # mapreduce.map.memory.mb     
> # mapreduce.map.cpu.vcores
> # mapred.child.env
> # mapred.child.java.opts      
> # mapred.job.queue.name  - ability to set launcher queue
> E.g. We were using mapred.child.env to pass SPARK_HOME to the LauncherMapper 
> and make PySpark work. 
> Fixing OOZIE-2596 added a hack. We should decide how we support or break 
> compatibility and how we allow the manipulation of the Launcher environment.
> Verify if the new launcher section in global applies to actions in 
> sub-workflows as well. It did not use to work before and was only fixed in 
> OOZIE-2030. It would be good to have that testcase 
> (TestSubWorkflowActionExecutor. testParentGlobalConf) updated with the new 
> launcher section as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to