[ 
https://issues.apache.org/jira/browse/OOZIE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166096#comment-16166096
 ] 

Attila Sasvari commented on OOZIE-2687:
---------------------------------------

Thanks [~rkanter] for your response! I opened OOZIE-3056.

In the mean time, jenkins build job finished with Patch 11: 
https://builds.apache.org/job/PreCommit-OOZIE-Build/18/console
Results:
{code}
+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
    +1 the patch does not introduce any @author tags
    +1 the patch does not introduce any tabs
    +1 the patch does not introduce any trailing spaces
    -1 the patch contains 5 line(s) longer than 132 characters
    +1 the patch does adds/modifies 9 testcase(s)
+1 RAT
    +1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
    +1 the patch does not seem to introduce new Javadoc warnings
    WARNING: the current HEAD has 77 Javadoc warning(s)
+1 COMPILE
    +1 HEAD compiles
    +1 patch compiles
    +1 the patch does not seem to introduce new javac warnings
0 There are [2] new bugs found in total that would be nice to have fixed.
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [tools].
 0 There are [2] new bugs found in [core] that would be nice to have fixed.
 You can find the FindBugs diff here: core/findbugs-new.html
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
+1 BACKWARDS_COMPATIBILITY
    +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
    +1 the patch does not modify JPA files
+1 TESTS
    Tests run: 2029
    Tests rerun: 53
    Tests failed at first run: 
org.apache.oozie.command.coord.TestCoordActionsKillXCommand,org.apache.oozie.action.hadoop.TestJavaActionExecutor,
+1 DISTRO
    +1 distro tarball builds with the patch 
{code}

Only issue: {{-1 the patch contains 5 line(s) longer than 132 characters}}


For some reason, comment was not added here:
{code}
Adding comment to JIRA
Could not find issue with key: 'OOZIE-2687'

Remote error: ; nested exception is: 
        java.net.SocketException: Connection reset
{code}

[~gezapeti], [~pbacsko], [~rkanter] please take a look at the latest patch and 
let me if you have any other review comments. Documentation will be done as 
part of OOZIE-2600.

> Create XML schema for launcher configurations
> ---------------------------------------------
>
>                 Key: OOZIE-2687
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2687
>             Project: Oozie
>          Issue Type: Sub-task
>    Affects Versions: 5.0.0
>            Reporter: Peter Cseh
>            Assignee: Attila Sasvari
>            Priority: Critical
>         Attachments: OOZIE-2687-001.patch, OOZIE-2687-002.patch, 
> OOZIE-2687-003.patch, OOZIE-2687-008.patch, OOZIE-2687-009.patch, 
> OOZIE-2687-010.patch, OOZIE-2687-011.patch
>
>
> It was possible to manipulate the MapperLauncher's environment through 
> properties like:
> # mapreduce.map.memory.mb     
> # mapreduce.map.cpu.vcores
> # mapred.child.env
> # mapred.child.java.opts      
> # mapred.job.queue.name  - ability to set launcher queue
> E.g. We were using mapred.child.env to pass SPARK_HOME to the LauncherMapper 
> and make PySpark work. 
> Fixing OOZIE-2596 added a hack. We should decide how we support or break 
> compatibility and how we allow the manipulation of the Launcher environment.
> Verify if the new launcher section in global applies to actions in 
> sub-workflows as well. It did not use to work before and was only fixed in 
> OOZIE-2030. It would be good to have that testcase 
> (TestSubWorkflowActionExecutor. testParentGlobalConf) updated with the new 
> launcher section as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to