> On July 30, 2018, 10:46 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > > Lines 708-712 (patched) > > <https://reviews.apache.org/r/68102/diff/1/?file=2065132#file2065132line774> > > > > Please use latest schema version `1.0`.
I don't think we should give up test coverage for older schemas. We should keep around the old ones in test and make sure to add enough covergave for new schemas when we add them. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/#review206592 ----------------------------------------------------------- On July 30, 2018, 8:42 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68102/ > ----------------------------------------------------------- > > (Updated July 30, 2018, 8:42 a.m.) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > Tags were not generated properly for external child jobs launched from subWFs > and they were not killed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > a1a9671ab > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > fdca5706e > > core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > e074d482f > > > Diff: https://reviews.apache.org/r/68102/diff/1/ > > > Testing > ------- > > Tested manually. > Added Junit test. > > > Thanks, > > Kinga Marton > >
