----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/#review206739 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java Lines 931-932 (patched) <https://reviews.apache.org/r/68102/#comment289831> Can be `final`. core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java Lines 946-947 (patched) <https://reviews.apache.org/r/68102/#comment289832> Can be `final`. - András Piros On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68102/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2018, 9:59 a.m.) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > Tags were not generated properly for external child jobs launched from subWFs > and they were not killed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > a1a9671ab > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > fdca5706e > > core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > e074d482f > > > Diff: https://reviews.apache.org/r/68102/diff/2/ > > > Testing > ------- > > Tested manually. > Added Junit test. > > > Thanks, > > Kinga Marton > >