[
https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
B.J. Reed updated OPENJPA-1015:
-------------------------------
Attachment: OPENJPA-1015-newlineendoffile.patch
The OPENJPA-1015-newlineendoffile.patch file is to fix the 20 or so files that
do not end the file with a new line character. It also includes a license in
the checkstyle.xml so that will be taken care of.
This should be applied after the max80character patch, but the 2 .xml files
won't go in quite right so the committer will need to do a little work on them.
> Enforce 80-column line width for source code
> --------------------------------------------
>
> Key: OPENJPA-1015
> URL: https://issues.apache.org/jira/browse/OPENJPA-1015
> Project: OpenJPA
> Issue Type: Test
> Reporter: Pinaki Poddar
> Assignee: B.J. Reed
> Attachments: line80.txt, OPENJPA-1015-max80chars.patch,
> OPENJPA-1015-newlineendoffile.patch, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding.
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of
> brackets etc?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
