[
https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Donald Woods updated OPENJPA-1015:
----------------------------------
Attachment: OPENJPA-1015-audit-output.patch
Patch which turns on auditing output, so we know which file failed the check.
Causes output listing the failing file(s), like -
[INFO] [checkstyle:checkstyle {execution: default}]
[INFO] Starting audit...
/Users/drwoods/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DB2Dictionary.java:848:
Line is longer than 80 characters.
Audit done.
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] An error has occurred in Checkstyle report generation.
Embedded error: There are 1 checkstyle errors.
> Enforce 80-column line width for source code
> --------------------------------------------
>
> Key: OPENJPA-1015
> URL: https://issues.apache.org/jira/browse/OPENJPA-1015
> Project: OpenJPA
> Issue Type: Test
> Reporter: Pinaki Poddar
> Assignee: B.J. Reed
> Attachments: line80.txt, OPENJPA-1015-audit-output.patch,
> OPENJPA-1015-checkstyle.xml.patch, OPENJPA-1015-max80chars.patch,
> OPENJPA-1015-newlineendoffile.patch, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding.
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of
> brackets etc?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
