[
https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695419#action_12695419
]
Michael Dick commented on OPENJPA-1015:
---------------------------------------
Thanks for the patch Don, that's much more helpful.
Note that we're not checking test files at the moment. The change to add that
in would be to add
<includeTestSourceDirectory>true</includeTestSourceDirectory>
to the <configuration> tag.
I'm expecting fixing those to be another big change. Anyone opposed to doing
the tests as well?
> Enforce 80-column line width for source code
> --------------------------------------------
>
> Key: OPENJPA-1015
> URL: https://issues.apache.org/jira/browse/OPENJPA-1015
> Project: OpenJPA
> Issue Type: Test
> Reporter: Pinaki Poddar
> Assignee: B.J. Reed
> Attachments: line80.txt, OPENJPA-1015-audit-output.patch,
> OPENJPA-1015-checkstyle.xml.patch, OPENJPA-1015-max80chars.patch,
> OPENJPA-1015-newlineendoffile.patch, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding.
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of
> brackets etc?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
