Awesome. Thanks Romain

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, May 25, 2021 at 4:20 PM Romain Manni-Bucau <rmannibu...@gmail.com>
wrote:

> Le mar. 25 mai 2021 à 15:41, Jean-Louis Monteiro <jlmonte...@tomitribe.com
> >
> a écrit :
>
> > I'll create a ticket then and checkout master to contribute it.
> > We can discuss after how I can help in the jakarka version of it
> >
>
> While a string which ends up in the constant pool the relocation we have in
> place should do it for you, just needs to ensure it worked to avoid
> surprises but I don't expect any action except "validation" one.
>
>
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Tue, May 25, 2021 at 3:21 PM Romain Manni-Bucau <
> rmannibu...@gmail.com>
> > wrote:
> >
> > > Hi JL,
> > >
> > > Looks accurate to me done with javax on master (and likely properly
> > > rewritten in our relocation/jakarta artifact).
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le mar. 25 mai 2021 à 15:12, Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com
> > > >
> > > a écrit :
> > >
> > > > Hi,
> > > >
> > > > In order to pass TCK for TomEE, I had to patch OpenJPA to avoid side
> > > > effects with other providers such as EclipseLink for instance.
> > > >
> > > > The change I made makes sense to be included in OpenJPA in my
> opinion.
> > > > But I'd like to gather some thoughts for this change
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/tomee-jakarta/commit/4d579785f7554c59b83d0060ec8c1ead81385738#diff-1aba75a7cc55951fb938c64a533fc9de63c3139b3aec5cf1279a96394d910b1e
> > > >
> > > > I can create a JIRA ticket and submit a PR to OpenJPA if you guys
> think
> > > it
> > > > makes sense.
> > > > In essence it prevents OpenJPA from doing something when a JPA
> provider
> > > is
> > > > explicitly specified.
> > > >
> > > > It will only do something if no JPA provider is specified or if
> OpenJPA
> > > is
> > > > the JPA provider configured.
> > > >
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > >
> >
>

Reply via email to