On 02/06/2013 12:50 PM, Kay Schenk wrote:
On 02/06/2013 06:15 AM, Michael Lam wrote:
On 02/06/2013 05:57 AM, Herbert Duerr wrote:
I just saw that Ariel had already provided an excellent answer when I
had trouble with my mail connection. Sorry about that.
On 06.02.2013 11:49, Herbert Duerr wrote:
Hi Michael,
On 06.02.2013 04:06, Michael Lam wrote:
I would like to update some of the Java libraries used, starting with
hsqldb. Is there any preference to getting the source and building
the
jar or just grabbing the jar from the project site?
Some other Apache projects are redistributing unmodified upstream
JARs,
so I guess we could do this as well and this would simplify the build.
There are four BZ
issues in reference to hsqldb with patches, I am going to test the
new
version to make sure those issues are resolved but they are very old.
Should I open another issue for this?
Opening just one issue with task about updating hsqldb should suffice.
Is there any recommendation/objection on this? After hsqldb I would
like
to move on to lucene.
Thank you very much for working on this!
Just a general question, there are many old issues on BZ for example
there are 96 for hsqldb but most of them are from 2006 and is
referring
to an old version of OpenOffice, would it be possible to close
very old
issues?
Sure, obsolete issues can be closed. Quickly skimping over the list of
hsqldb issues [1] shows that some problems may be generic and could
still be relevant. Having their reports and descriptions on how to
reproduce them could be valuable enough to reconsider closing them.
Maybe they are interesting test cases when you upgraded hsqldb?
[1] http://s.apache.org/aoo_hsqldb_open
Herbert
Thank you Herbert and Ariel. I already have a build with the latest code
from SVN and the latest jar from hsqldb. I was thinking the same as
using the existing issues especially the one with the patches as test
cases to make sure the new jar doesn't introduce regression.
Good going Michael!! Ok, you used latest HSQLDB jar, hsqldb-2.2.9, and
which version of java on your system?
And yes, looking through old dba dev mail archives did prove
useful/interesting, as well as information starting in:
http://www.openoffice.org/dba/
I can look into updating the files both ways to build but I would think
it is better to just retrieve the jar and simplify the build process. As
a new volunteer, the current process is quite complex even with the
great documentation. I think simplifying it by concentrating on the core
openoffice code would be helpful.
I have successfully test hsqldb-2.2.9 against the following 4 issues and
it is functioning correctly:
https://issues.apache.org/ooo/show_bug.cgi?id=96823
https://issues.apache.org/ooo/show_bug.cgi?id=103528
https://issues.apache.org/ooo/show_bug.cgi?id=104901
https://issues.apache.org/ooo/show_bug.cgi?id=97032
and I have looked at
http://hg.services.openoffice.org/cws/hsqldb19/
Unless I am looking at this wrong, many of the changes are not related to
hsqldb19 and it is already in the latest revision. As for the hsqldb specific,
the patches does not apply to 2.2.9. As far as patches, wouldn't it be better
to report upstream and provide the patch instead of just patching within the
build? There are also checks within the code to specifically check for version
1.8.x, not sure wouldn't it be better to enforce on configure/bootstrap? The
current way seem to require a lot more work to update dependencies and the
with-system-hsqldb for configure provides no warning.
I will take a look at the open issues and see if it is resolved with the new
version.
I am guessing my next steps would be looking into updating the build to pull
the jar?
Michael
