+1 I like the page. Is it also worth publishing somehow as a blog so outsiders notice it.
I think you have a typo near the end "VCS revision". Have a nice day. rgds Jan I. On 13 February 2013 15:52, Rob Weir <robw...@apache.org> wrote: > On Tue, Feb 12, 2013 at 5:47 PM, janI <j...@apache.org> wrote: > > On 12 February 2013 23:19, Rob Weir <robw...@apache.org> wrote: > > > >> We had a thread before Christmas discussing code contributions and > >> best practices for how someone could contribute code to multiple > >> projects, e.g., AOO and LO. > >> > >> I've written this up, along with more general remarks on contributing > >> code on a new page: > >> > >> http://openoffice.apache.org/contributing-code.html > >> > >> Please take a look and let me know of any needed/recommended changes. > >> > > Nice page, however I do not like "We're not interested in large > > code-dumps.", I would prefer if you wrote something like: > > > > OK. I rewrote this section to be more positive: > > http://openoffice.apache.org/contributing-code.html > > > Regards, > > -Rob > > > > > "Integrating large code-dumps requires cooperation and cannot be done as > a > > simple commit, therefore we urge you to contact us on how we commonly can > > achieve the best result". > > > > When I read the page, it sounds as if we are only interested in small > code > > patches, and that cannot be correct. Of course if someone has written a > > function (maybe 1.000 lines), we are highly interested. If someone has > > written a complete new module (like a photo editor), then we need to > talk. > > > > As an example my l10n tools are about 1.100 lines which I am sure is > > something we want (I know I am committer, but see it as an example). > > > > rgds > > Jan I. > > > > > > > >> Thanks, > >> > >> -Rob > >> >
