Hello Marcin,
Marcin Miłkowski wrote:
Hi Andre,
2. The previews in the template documents (from which the master
pages are taken) look differently from the previews used in the
master page controls. The former do not show the placeholder shapes
on the master pages. That is because the previews in the documents
are made for the first slide of the document not its master page.
OK. So probably we could solve this by simply moving the code for
creating the thumbnail for the master page to the place where the
thumbnail for the file is created, and solve the issue for template
thumbnails and caching at the same time. The code could also rewrite
thumbnails for templates created with OOo < 3.1.
Yes we could do that and it would solve this very special problem.
But in all other areas where the document previews are used you would
see the master page previews as well. Hardly desirable. Maybe we
could write different document previews for template documents and all
other documents but even that may be too simple a solution.
Definitely, templates need different previews than simple documents.
Isn't the issue 43354 exactly about this?
You keep mentioning issue 43354. Just to make sure that we are talking
about the same thing, the summary of issue 43354 is "Master Design
slides get deleted when no slide uses them". That issue is not about
the display of master page previews. It is about deleting or keeping
master pages from/in a document. Deleting a master page does of course
affect the set of master page previews in the "Used in this
presentation" control but that is probably not what you mean.
> What is too simple about my solution?
We have to be very careful when we change a feature (creation of
document preview) that is used in many places (well, the previews are
used, not the creation). In other places, where the document previews
are displayed, it may be undesirable to show previews of master pages
for template documents. It may or it may not. I don't know. Do you?
Unless you can guarantee me that changing this feature will not cause
other problems to arise, we can not do it.
This very special problem, as you call it, causes OOo to freeze for 2
minutes if you have more than 20 templates. Which means that OOo is
almost unusable with templates because this happens every time you try
to apply a template from the extension. Install more templates and
you'll see :/ I found this by creating an extension that contains new
templates for OOo:
http://extensions.services.openoffice.org/project/modern-impress-templates
So this is hardly an artifact and it cripples OOo :(
Please don't get me wrong. The creation of master page previews takes
too long. There is no doubt about that.
And "this very special problem" is probably the wrong phrase. It should
be "this very problem". I am sorry, I am not a native english speaker.
3. Using a persistent cache for storing the previews has its own set
of problems and, of course, has to be created from scratch.
4. The current solution has the advantage that previews for the
template documents are created in the same way as the previews for
master pages that are in use by the current document: just render
the master pages in question.
There is another issue probably connected to caching the extension
paths: if you uninstall the template extension and install it again,
there will be no page previews as the paths are wrong (they point to
the uninstalled extension). I will write the issue about this but I'm
not sure to whom I should assign it.
I don't understand. You want to write an issue for a proposed
behavior that has not been implemented and maybe never will?
Probably I was unclear. There is a bug with extension installation
mechanisms. See:
http://qa.openoffice.org/issues/show_bug.cgi?id=94955
I see. I will keep this problem in mind (and it seems to be in the
right hands.)
None of the reasons above really prevents us from changing the
current behavior (which I am not happy with either). The problem is
not technical either. All of the technical problems mentioned above
can be solved.
The main problems are a) coming up with a good solution and convince
people that it is better than the current state and b) get the time
to apply that solution.
I think I already have a);
I am sorry but no, we do not yet have a good solution.
OK, what's wrong with my idea? Probably you're right it's not a good
solution but giving a reason might help me a little. Saying it's wrong
is not really helpful as I don't know yet why.
Well, I think we were both referring to what we wrote earlier (otherwise
I could reply "saying you have a good solution is not really helpful" :-).
Look, we are both on the same side. We both agree that there is an ugly
problem. We just differ on how to fix it. I have to make sure that by
fixing one thing we do not break another.
and b) should be quite easy, it's about moving the code and writing a
simple test of the version of OOo that created the file.
No, nothing of the two is really easy. You will see if you really try
to do it that way.
Probably the code isn't modular enough. That's possible.
Regards,
Marcin
Best regards,
Andre
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
