Hi Andre,

2. The previews in the template documents (from which the master pages are taken) look differently from the previews used in the master page controls. The former do not show the placeholder shapes on the master pages. That is because the previews in the documents are made for the first slide of the document not its master page.

OK. So probably we could solve this by simply moving the code for creating the thumbnail for the master page to the place where the thumbnail for the file is created, and solve the issue for template thumbnails and caching at the same time. The code could also rewrite thumbnails for templates created with OOo < 3.1.

Yes we could do that and it would solve this very special problem. But in all other areas where the document previews are used you would see the master page previews as well. Hardly desirable. Maybe we could write different document previews for template documents and all other documents but even that may be too simple a solution.

Definitely, templates need different previews than simple documents. Isn't the issue 43354 exactly about this? What is too simple about my solution?

This very special problem, as you call it, causes OOo to freeze for 2 minutes if you have more than 20 templates. Which means that OOo is almost unusable with templates because this happens every time you try to apply a template from the extension. Install more templates and you'll see :/ I found this by creating an extension that contains new templates for OOo:

http://extensions.services.openoffice.org/project/modern-impress-templates

So this is hardly an artifact and it cripples OOo :(

3. Using a persistent cache for storing the previews has its own set of problems and, of course, has to be created from scratch.

4. The current solution has the advantage that previews for the template documents are created in the same way as the previews for master pages that are in use by the current document: just render the master pages in question.

There is another issue probably connected to caching the extension paths: if you uninstall the template extension and install it again, there will be no page previews as the paths are wrong (they point to the uninstalled extension). I will write the issue about this but I'm not sure to whom I should assign it.

I don't understand. You want to write an issue for a proposed behavior that has not been implemented and maybe never will?

Probably I was unclear. There is a bug with extension installation mechanisms. See:

http://qa.openoffice.org/issues/show_bug.cgi?id=94955

None of the reasons above really prevents us from changing the current behavior (which I am not happy with either). The problem is not technical either. All of the technical problems mentioned above can be solved. The main problems are a) coming up with a good solution and convince people that it is better than the current state and b) get the time to apply that solution.

I think I already have a);

I am sorry but no, we do not yet have a good solution.

OK, what's wrong with my idea? Probably you're right it's not a good solution but giving a reason might help me a little. Saying it's wrong is not really helpful as I don't know yet why.

and b) should be quite easy, it's about moving the code and writing a simple test of the version of OOo that created the file.

No, nothing of the two is really easy. You will see if you really try to do it that way.

Probably the code isn't modular enough. That's possible.

Regards,
Marcin

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to