Except the default to bytecode for java 8 - fear we have to stick to j6 or 7 if we want to change here - it looks good.
Le mar. 20 nov. 2018 20:59, Thomas Andraschko <andraschko.tho...@gmail.com> a écrit : > @Romain could you do a short review? I could apply it tomorrow then. > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha < > daniels...@gmail.com>: > > > Hi Thomas, > > > > I've updated the patch[1], please review it. > > Thank you. > > > > [1] https://github.com/apache/openwebbeans/pull/13 > > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <daniels...@gmail.com> > > escreveu: > > > > > Hi Thomas, > > > > > > sure. I'll working on it. In the same patch. > > > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko < > > > andraschko.tho...@gmail.com> escreveu: > > > > > >> Yep. Could you please provide a PR (or even a patch - i have to merge > it > > >> manually), so i can commit both? > > >> > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha < > > >> daniels...@gmail.com>: > > >> > > >> > Hi Thomas, > > >> > > > >> > Good catch! if we want to have support for java 11 (officially) on > OWB > > >> > 1.7.x, maybe is better to move it to use asm7 as well. > > >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko < > > >> > andraschko.tho...@gmail.com> escreveu: > > >> > > > >> > > I could merge it, too but does it really make sense to apply it > > >> without > > >> > > migrating to asm7? > > >> > > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha < > > >> > > daniels...@apache.org>: > > >> > > > > >> > > > Hi Romain, > > >> > > > > > >> > > > Do we have plan to merge it? > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau < > > >> > > > rmannibu...@gmail.com> > > >> > > > escreveu: > > >> > > > > > >> > > > > Hello Daniel, > > >> > > > > > > >> > > > > it is ok for me > > >> > > > > > > >> > > > > Romain Manni-Bucau > > >> > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > >> > > > > <https://rmannibucau.metawerx.net/> | Old Blog > > >> > > > > <http://rmannibucau.wordpress.com> | Github < > > >> > > > > https://github.com/rmannibucau> | > > >> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > >> > > > > < > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha < > > daniels...@apache.org> > > >> a > > >> > > > écrit > > >> > > > > : > > >> > > > > > > >> > > > > > Hi Romain, > > >> > > > > > > > >> > > > > > So, the change sounds good to go? Or you still see something > > to > > >> be > > >> > > > > changed? > > >> > > > > > > > >> > > > > > > > >> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha < > > >> > daniels...@gmail.com > > >> > > > > > escreveu: > > >> > > > > > > > >> > > > > > > Hi Romain, > > >> > > > > > > > > >> > > > > > > You right, the backport include other things which are > > >> important > > >> > as > > >> > > > > well > > >> > > > > > > like: > > >> > > > > > > changes on NormalScopeProxyFactory and > > >> > > > > InterceptorDecoratorProxyFactory. > > >> > > > > > > > > >> > > > > > > But yes, the backport includes the commit that you refer. > :) > > >> > > > > > > > > >> > > > > > > Thank you for your review. > > >> > > > > > > > > >> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau < > > >> > > > > > > rmannibu...@gmail.com> escreveu: > > >> > > > > > > > > >> > > > > > >> Ok I get it now, so this is not *this* commit you want > but > > >> one > > >> > > > before > > >> > > > > - > > >> > > > > > >> likely > > >> > > > > > >> > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513 > > >> > > > > > >> - but it was included in the commit you backported ;). > > >> > > > > > >> > > >> > > > > > >> makes sense to include that in 1.7 branch IMHO > > >> > > > > > >> > > >> > > > > > >> Romain Manni-Bucau > > >> > > > > > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > > >> > > > > > >> <https://rmannibucau.metawerx.net/> | Old Blog > > >> > > > > > >> <http://rmannibucau.wordpress.com> | Github < > > >> > > > > > >> https://github.com/rmannibucau> | > > >> > > > > > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | > Book > > >> > > > > > >> < > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha < > > >> > daniels...@apache.org> > > >> > > a > > >> > > > > > >> écrit : > > >> > > > > > >> > > >> > > > > > >> > Of course, the issue happening when I'm using JDK11 :) > > >> > > > > > >> > > > >> > > > > > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha < > > >> > > > > daniels...@gmail.com > > >> > > > > > > > > >> > > > > > >> > escreveu: > > >> > > > > > >> > > > >> > > > > > >> > > Hi Romain, > > >> > > > > > >> > > > > >> > > > > > >> > > Well... that change make me possible to continue > create > > >> my > > >> > > > > singleton > > >> > > > > > >> > > startup like it: > > >> > > > > > >> > > > > >> > > > > > >> > > import javax.annotation.PostConstruct; > > >> > > > > > >> > > import javax.annotation.PreDestroy; > > >> > > > > > >> > > import javax.ejb.Singleton; > > >> > > > > > >> > > import javax.ejb.Startup; > > >> > > > > > >> > > > > >> > > > > > >> > > @Singleton > > >> > > > > > >> > > @Startup > > >> > > > > > >> > > public class KernelShutdownListener { > > >> > > > > > >> > > > > >> > > > > > >> > > @PostConstruct > > >> > > > > > >> > > private void startup() { > > >> > > > > > >> > > System.out.println("ALOHA STARTUP"); > > >> > > > > > >> > > } > > >> > > > > > >> > > > > >> > > > > > >> > > @PreDestroy > > >> > > > > > >> > > private void shutdown() { > > >> > > > > > >> > > System.out.println("ALOHA SHUTDOWN"); > > >> > > > > > >> > > } > > >> > > > > > >> > > } > > >> > > > > > >> > > > > >> > > > > > >> > > It was not possible without that change, as you can > see > > >> > here: > > >> > > > > > >> > > Caused by: java.lang.IllegalStateException: Cannot > get > > >> > > > > > >> Unsafe.defineClass > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801) > > >> > > > > > >> > > at > > >> > > > > java.base/java.security.AccessController.doPrivileged(Native > > >> > > > > > >> > Method) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.proxy.AbstractProxyFactory.<init>(AbstractProxyFactory.java:91) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.<init>(InterceptorDecoratorProxyFactory.java:77) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.config.WebBeansContext.<init>(WebBeansContext.java:153) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.config.WebBeansContext.<init>(WebBeansContext.java:116) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167) > > >> > > > > > >> > > at > > >> > > > org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:963) > > >> > > > > > >> > > ... 17 more > > >> > > > > > >> > > Caused by: java.lang.NoSuchMethodException: > > >> > > > > > >> > > sun.misc.Unsafe.defineClass(java.lang.String, [B, > int, > > >> int, > > >> > > > > > >> > > java.lang.ClassLoader, > java.security.ProtectionDomain) > > >> > > > > > >> > > at > > >> > > > > java.base/java.lang.Class.getDeclaredMethod(Class.java:2476) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:807) > > >> > > > > > >> > > ... 27 more > > >> > > > > > >> > > > > >> > > > > > >> > > 05-Nov-2018 15:15:33.110 SEVERE > [localhost-startStop-2] > > >> > > > > > >> > > jdk.internal.reflect.NativeMethodAccessorImpl.invoke > > >> Error > > >> > > > > deploying > > >> > > > > > >> web > > >> > > > > > >> > > application archive > > >> > > > > > >> [/tmp/apache-tomee-plume-7.0.6-TT.2/webapps/ROOT.war] > > >> > > > > > >> > > java.lang.IllegalStateException: > > ContainerBase.addChild: > > >> > > start: > > >> > > > > > >> > > org.apache.catalina.LifecycleException: Failed to > start > > >> > > > component > > >> > > > > > >> > > > > >> > > > > > > >> [StandardEngine[Catalina].StandardHost[localhost].StandardContext[]] > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:758) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > >> > > > > > > >> > > > org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:730) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > > > >> > > org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > > > >> > > org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:985) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1857) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) > > >> > > > > > >> > > at > > >> > > > > > >> > > >> > java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > > >> > > > > > >> > > at > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > > >> > > > > > >> > > at > java.base/java.lang.Thread.run(Thread.java:834) > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > Em seg, 5 de nov de 2018 às 15:24, Romain > Manni-Bucau < > > >> > > > > > >> > > rmannibu...@gmail.com> escreveu: > > >> > > > > > >> > > > > >> > > > > > >> > >> Hi Daniel, > > >> > > > > > >> > >> > > >> > > > > > >> > >> Do you know which part implies the "need", this > commit > > >> was > > >> > > not > > >> > > > > > >> suppose > > >> > > > > > >> > to > > >> > > > > > >> > >> change anything since the code was already > supporting > > >> java > > >> > > 11, > > >> > > > it > > >> > > > > > was > > >> > > > > > >> > just > > >> > > > > > >> > >> intended to prepare potential change later on. > > >> > > > > > >> > >> Did a small change in the behavior was introduced - > if > > >> so > > >> > it > > >> > > > was > > >> > > > > > not > > >> > > > > > >> > >> intended from my part? > > >> > > > > > >> > >> > > >> > > > > > >> > >> Romain Manni-Bucau > > >> > > > > > >> > >> @rmannibucau <https://twitter.com/rmannibucau> | > > Blog > > >> > > > > > >> > >> <https://rmannibucau.metawerx.net/> | Old Blog > > >> > > > > > >> > >> <http://rmannibucau.wordpress.com> | Github < > > >> > > > > > >> > >> https://github.com/rmannibucau> | > > >> > > > > > >> > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> > | > > >> Book > > >> > > > > > >> > >> < > > >> > > > > > >> > >> > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > >> > > > > > >> > >> > > > >> > > > > > >> > >> > > >> > > > > > >> > >> > > >> > > > > > >> > >> Le lun. 5 nov. 2018 à 19:20, Daniel Cunha < > > >> > > > daniels...@apache.org > > >> > > > > > > > >> > > > > > a > > >> > > > > > >> > >> écrit : > > >> > > > > > >> > >> > > >> > > > > > >> > >> > Hi Folks, > > >> > > > > > >> > >> > > > >> > > > > > >> > >> > we got an issue with Java 11 and TomEE 7.0.x and > we > > >> need > > >> > > the > > >> > > > > > >> backport > > >> > > > > > >> > >> for > > >> > > > > > >> > >> > it: > > >> > > > > > >> > >> > https://github.com/apache/openwebbeans/pull/13 > > >> > > > > > >> > >> > > > >> > > > > > >> > >> > Please take a look at those changes and let me > know > > >> what > > >> > do > > >> > > > you > > >> > > > > > >> think. > > >> > > > > > >> > >> > > > >> > > > > > >> > >> > Thank you. > > >> > > > > > >> > >> > -- > > >> > > > > > >> > >> > Daniel "soro" Cunha > > >> > > > > > >> > >> > https://twitter.com/dvlc_ > > >> > > > > > >> > >> > > > >> > > > > > >> > >> > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > -- > > >> > > > > > >> > > Daniel "soro" Cunha > > >> > > > > > >> > > https://twitter.com/dvlc_ > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > > >> > > > > > >> > -- > > >> > > > > > >> > Daniel "soro" Cunha > > >> > > > > > >> > https://twitter.com/dvlc_ > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > -- > > >> > > > > > > Daniel "soro" Cunha > > >> > > > > > > https://twitter.com/dvlc_ > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > -- > > >> > > > Daniel "soro" Cunha > > >> > > > https://twitter.com/dvlc_ > > >> > > > > > >> > > > > >> > > > >> > > > >> > -- > > >> > Daniel "soro" Cunha > > >> > https://twitter.com/dvlc_ > > >> > > > >> > > > > > > > > > -- > > > Daniel "soro" Cunha > > > https://twitter.com/dvlc_ > > > > > > > > > -- > > Daniel "soro" Cunha > > https://twitter.com/dvlc_ > > >
