[
https://issues.apache.org/jira/browse/OWB-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897843#comment-16897843
]
Greg Wilkins commented on OWB-1293:
-----------------------------------
Ummm sorry but I really don't like that patch to our ListenerHolder. The
holder is already essentially a proxy which we use to delay instantiating
classes until all the SCIs have run and thus all the decorators are in
place..... so have a proxy create a proxy... you end up turtles all the way
down.
I don't think it is hacky to move to a SCI, as that is precisely where such
things are meant to be setup! I've updated our example webapp to use this
SCI:
[https://github.com/eclipse/jetty.project/blob/jetty-9.4.x-3804-Decoration/tests/test-webapps/test-owb-cdi-webapp/src/main/java/org/eclipse/jetty/cdi/owb/OwbServletContainerInitializer.java]
Note that while the standard does not allow it, Jetty does have an ordering
mechanism for SCIs, so if need be we can ensure that this SCI runs before or
after other SCIs.
With this SCI, the test-owb-cdi-webapp starts fine using the new cdi module
(may be renamed to cdi-spi).
But strangely enough it does not work with the old cdi2 module? Is there
something else I need to do to trigger the jetty integration that works with
the APIs exposed by the cdi2 module?
> Update Jetty integration prior to Jetty-10 release
> --------------------------------------------------
>
> Key: OWB-1293
> URL: https://issues.apache.org/jira/browse/OWB-1293
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Interceptor and Decorators
> Reporter: Greg Wilkins
> Priority: Major
>
> The current jetty integration relies on exposing private jetty APIs so a
> jetty Decorator can be registered. This is fragile and requires different
> APIs for the upcoming jetty-10 release.
> Instead, Jetty is developing a mechanism where a object with a decorator
> signature can be set as a context attribute and it will be introspected and
> dynamically registered as a decorator without any API dependencies.
> This is currently being developed in
> [https://github.com/eclipse/jetty.project/pull/3838] and an integration with
> Weld is at [https://github.com/weld/core/pull/1926]
> Feedback is sought from the OpenWebBeans team on the approach and then we'd
> like to collaborate to make a similar integration.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
