[
https://issues.apache.org/jira/browse/OWB-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898389#comment-16898389
]
Greg Wilkins commented on OWB-1293:
-----------------------------------
Romain,
SCIs are a much better places to setup CDI and you don't get the same problem
because:
# We don't decorate SCIs, so there is not the problem of needing to decorate
the SCI+1. Even if we later decided that SCIs should be decorated, at least we
have ordering and the points below to make it better than listeners.
# SCIs are only discovered by the container, thus at an early point in the
context init, we have a list of all SCIs (which we can order) and then we
invoke. Unlike listeners, SCIs cannot be added programmaticaly, so we don't
have to deal with new SCIs on the fly.
# Any listener/filter/servlet added by class name by any SCI will be
instantiated/decoratored after all the SCIs have executed, so the order of the
SCIs execution is not so critical
So given that, it's great that you are adding an SCI mechanism. I see it is in
1.2.9, but I'm currently using OWB-2.0.11, so will it be in a 2.0.12 soon?
One quibble with it, the context specific init param should probably override
the globally set system property, but other than that it looks equivalent to
the SCI I've tested.
With regards to the cdi2 module, it is just opening up the classloader so the
jetty specific decorate APIs are visible. It should then allow the previous
Jetty integration to work as it would have before. Is there something I need
to do to make the previous jetty integration trigger?... Ah I see I need to
[add a jetty specific decorator to the object
factor|[https://github.com/apache/openwebbeans/blob/master/webbeans-jetty9/README.asciidoc|https://github.com/apache/openwebbeans/blob/master/webbeans-jetty9/README.asciidoc)]]
Hmmm it would be good to make that a noop and give a warning if it detected
the CdiDecorator being enabled (via context param).
> Update Jetty integration prior to Jetty-10 release
> --------------------------------------------------
>
> Key: OWB-1293
> URL: https://issues.apache.org/jira/browse/OWB-1293
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Interceptor and Decorators
> Reporter: Greg Wilkins
> Priority: Major
>
> The current jetty integration relies on exposing private jetty APIs so a
> jetty Decorator can be registered. This is fragile and requires different
> APIs for the upcoming jetty-10 release.
> Instead, Jetty is developing a mechanism where a object with a decorator
> signature can be set as a context attribute and it will be introspected and
> dynamically registered as a decorator without any API dependencies.
> This is currently being developed in
> [https://github.com/eclipse/jetty.project/pull/3838] and an integration with
> Weld is at [https://github.com/weld/core/pull/1926]
> Feedback is sought from the OpenWebBeans team on the approach and then we'd
> like to collaborate to make a similar integration.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
