belugabehr commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r697051661
##########
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##########
@@ -52,6 +53,8 @@
*/
void getText(Text result, int position);
+ ByteBuffer getText(int position);
Review comment:
From an OO designed perspective, I think it's better to keep the name as
is and treat is as overloaded method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
