stiga-huang commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r727893588
##########
File path: c++/src/Reader.cc
##########
@@ -35,6 +35,12 @@
#include <set>
namespace orc {
+ // ORC files writen by these versions of cpp writers have inconsistent bloom
filter
+ // hashing with the Java codes (ORC-1024). Bloom filters of them should not
be used
+ // after we fix ORC-1024.
Review comment:
Sorry that I'm not familiar with the code style here. I thought this can
explain why we consider the following versions bad. If one wants to know more,
he/she can go to the JIRA(ORC-1024) to understand more details. Otherwise,
he/she may need to use `git blame` to find this commit, and then get the JIRA
ID.
I think leaving JIRA ids in comments is a good practise in Impala's code
style. It helps to explain complex issues with a summarized comment. E.g.
https://github.com/apache/impala/blob/45fd3320ad4f68ca86998dff0c9504aa896a278a/be/src/runtime/runtime-state.h#L383-L385
I can remove this if you prefer not having this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
