dongjoon-hyun commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r727815056



##########
File path: java/core/src/java/org/apache/orc/util/BloomFilter.java
##########
@@ -246,6 +246,13 @@ public void reset() {
     this.bitSet.clear();
   }
 
+  /**
+   * Helper method that only used for tests. Use default visibility.
+   */
+  boolean testBitSetPos(int pos) {

Review comment:
       If this is used only once in `checkBitSet`, let's move this to a test 
class like `checkBitSet`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to