dongjoon-hyun commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r727809212
##########
File path: c++/src/Reader.hh
##########
@@ -179,6 +180,13 @@ namespace orc {
*/
void seekToRowGroup(uint32_t rowGroupEntryId);
+ /**
+ * Check if the file has bad bloom filters (ORC-1024). We will skip using
them in the
+ * following reads.
+ * @return true if it has.
+ */
+ bool checkBadBloomFilters();
Review comment:
For naming, `hasBadBloomFilters` is better in `Reader.hh`.
Although I understand that you use `checkXXX` here because you already have
a member variable `checkBadBloomFilters`, we had better focus on the public
interface more.
##########
File path: c++/src/Reader.hh
##########
@@ -179,6 +180,13 @@ namespace orc {
*/
void seekToRowGroup(uint32_t rowGroupEntryId);
+ /**
+ * Check if the file has bad bloom filters (ORC-1024). We will skip using
them in the
+ * following reads.
+ * @return true if it has.
+ */
+ bool checkBadBloomFilters();
Review comment:
For naming, `hasBadBloomFilters` is better in `Reader.hh`.
Although I understand that you use `checkXXX` here because you already have
a member variable `checkBadBloomFilters`, we had better focus on the public
interface more importantly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
