[GitHub] [orc] dongjoon-hyun commented on a change in pull request #1071: ORC-1137: [C++] Unroll loops and copy data directly in DoubleColumnReader::next()

[GitBox]

dongjoon-hyun commented on a change in pull request #1071:
URL: https://github.com/apache/orc/pull/1071#discussion_r837987572



##########
File path: c++/src/ColumnReader.cc
##########
@@ -412,10 +412,11 @@ namespace orc {
     nanoRle->seek(positions.at(columnId));
   }
 
+  template<TypeKind COLUMN_KIND, bool IS_LITTLE_ENDIAN>

Review comment:
       Although I know that this pattern is used before, this still looks 
misleading. For example, this PR is introducing the following which is very 
confusing because both one looks like CONSTANT.
   ```
   if (COLUMN_KIND == FLOAT) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org