dongjoon-hyun commented on a change in pull request #1071:
URL: https://github.com/apache/orc/pull/1071#discussion_r837990366
##########
File path: c++/src/ColumnReader.cc
##########
@@ -412,10 +412,11 @@ namespace orc {
nanoRle->seek(positions.at(columnId));
}
+ template<TypeKind COLUMN_KIND, bool IS_LITTLE_ENDIAN>
Review comment:
Is this the best practice for us to use as Apache ORC C++ coding
standard, @stiga-huang ? It's up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
