stiga-huang commented on a change in pull request #1071:
URL: https://github.com/apache/orc/pull/1071#discussion_r838023804
##########
File path: c++/src/ColumnReader.cc
##########
@@ -412,10 +412,11 @@ namespace orc {
nanoRle->seek(positions.at(columnId));
}
+ template<TypeKind COLUMN_KIND, bool IS_LITTLE_ENDIAN>
Review comment:
Thanks for raising this question! I think I should rename `COLUMN_KIND`
to `columnKind` and `IS_LITTLE_ENDIAN` to `isLittleEndian` since they are not
type names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
