Thanks, Ryan for highlighting this. With your vote we have the required three +1 binding votes. Let's wait for a couple of days if anyone has a problem with the thrift compatibility or anything else. I'll finalize the release in the beginning of next week if there are no objections.
Cheers, Gabor On Tue, Jan 7, 2020 at 7:41 PM Ryan Blue <[email protected]> wrote: > I think it's fine on the Java side because we compile and shade/relocate > the thrift dependency. > > On Tue, Jan 7, 2020 at 10:30 AM Wes McKinney <[email protected]> wrote: > > > Good observation -- Ubuntu 16.04 Xenial is still shipping the Thrift > > 0.9.x compiler. We don't support this version of Thrift libraries > > anymore in C++ so anyone building the project would need to use a > > newer version. I don't see it as a major issue > > > > On Tue, Jan 7, 2020 at 12:21 PM Ryan Blue <[email protected]> > > wrote: > > > > > > Looks like [this commit]( > > > > > > https://github.com/apache/parquet-format/commit/7390aa18ac855622f6d5cb737e9628eecd7565fd > > ) > > > broke compatibility with older versions of thrift. 0.9.3 doesn't have > an > > > `i8` type. I think it should be fine, but I wanted to highlight this in > > > case it is a concern for anyone. > > > > > > Otherwise, the release looks good. With thrift 0.12.0, the maven build > > and > > > tests succeed. Signature is valid once I imported KEYS and the sha512 > sum > > > is correct. > > > > > > +1 assuming there are no concerns about the thrift compatibility from > > > anyone. > > > > > > On Mon, Jan 6, 2020 at 4:46 AM Driesprong, Fokko <[email protected] > > > > > wrote: > > > > > > > Thank you, Gabor, for running the vote. > > > > > > > > A +1 (non-binding) from me as well. Checked the changes and it looks > > good > > > > to me. > > > > > > > > Cheers, Fokko > > > > > > > > Op ma 6 jan. 2020 om 13:39 schreef Gabor Szadovszky < > [email protected] > > >: > > > > > > > > > Hi All, > > > > > > > > > > We have two +1 binding votes so far. > > > > > Anyone is interested in checking/voting this release? > > > > > > > > > > Thanks a lot, > > > > > Gabor > > > > > > > > > > On Wed, Dec 18, 2019 at 10:06 AM Gabor Szadovszky < > [email protected]> > > > > > wrote: > > > > > > > > > > > Thanks, Wes. I also vote. > > > > > > +1 (binding) > > > > > > > > > > > > On Mon, Dec 16, 2019 at 6:51 PM Wes McKinney < > [email protected]> > > > > > wrote: > > > > > > > > > > > >> +1 (binding) > > > > > >> > > > > > >> The format changes in Parquet.thrift are what I expected > > > > > >> > > > > > >> > > > > > >> > > > > > > > > > > > > https://github.com/apache/parquet-format/compare/apache-parquet-format-2.7.0...apache-parquet-format-2.8.0-rc0 > > > > > >> > > > > > >> Also verified checksum and signature > > > > > >> > > > > > >> On Mon, Dec 16, 2019 at 7:57 AM Gabor Szadovszky < > > [email protected]> > > > > > >> wrote: > > > > > >> > > > > > > >> > Hi Everyone, > > > > > >> > > > > > > >> > I propose the following RC to be released as official Apache > > Parquet > > > > > >> Format > > > > > >> > 2.8.0 release. > > > > > >> > > > > > > >> > The commit id is 66cb393a0f4fe93cddc49345cc2a45490ea234e1 > > > > > >> > * This corresponds to the tag: apache-parquet-format-2.8.0-rc0 > > > > > >> > * > > > > > >> > > > > > > >> > > > > > > > > > > > > https://github.com/apache/parquet-format/tree/66cb393a0f4fe93cddc49345cc2a45490ea234e1 > > > > > >> > > > > > > >> > The release tarball, signature, and checksums are here: > > > > > >> > * > > > > > >> > > > > > > >> > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-format-2.8.0-rc0 > > > > > >> > > > > > > >> > You can find the KEYS file here: > > > > > >> > * https://apache.org/dist/parquet/KEYS > > > > > >> > > > > > > >> > Binary artifacts are staged in Nexus here: > > > > > >> > * > > > > > >> > > > > > > >> > > > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/parquet/parquet-format/2.8.0 > > > > > >> > > > > > > >> > This release includes changes listed here: > > > > > >> > * > > > > > >> > > > > > > >> > > > > > > > > > > > > https://github.com/apache/parquet-format/blob/apache-parquet-format-2.8.0-rc0/CHANGES.md > > > > > >> > > > > > > >> > Please download, verify, and test. > > > > > >> > > > > > > >> > Please vote in the next 72 hours. > > > > > >> > > > > > > >> > [ ] +1 Release this as Apache Parquet Format 2.8.0 > > > > > >> > [ ] +0 > > > > > >> > [ ] -1 Do not release this because... > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Ryan Blue > > > Software Engineer > > > Netflix > > > > > -- > Ryan Blue > Software Engineer > Netflix >
