ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r439797162
########## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/PropertiesDrivenCryptoFactory.java ########## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.parquet.crypto.keytools; + +import java.io.IOException; +import java.security.SecureRandom; +import java.util.HashMap; +import java.util.Map; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.parquet.crypto.ColumnEncryptionProperties; +import org.apache.parquet.crypto.DecryptionKeyRetriever; +import org.apache.parquet.crypto.DecryptionPropertiesFactory; +import org.apache.parquet.crypto.EncryptionPropertiesFactory; +import org.apache.parquet.crypto.FileDecryptionProperties; +import org.apache.parquet.crypto.FileEncryptionProperties; +import org.apache.parquet.crypto.ParquetCipher; +import org.apache.parquet.crypto.ParquetCryptoRuntimeException; +import org.apache.parquet.hadoop.api.WriteSupport.WriteContext; +import org.apache.parquet.hadoop.metadata.ColumnPath; + +import static org.apache.parquet.crypto.keytools.KeyToolkit.stringIsEmpty; + +public class PropertiesDrivenCryptoFactory implements EncryptionPropertiesFactory, DecryptionPropertiesFactory { + + public static final String COLUMN_KEYS_PROPERTY_NAME = "encryption.column.keys"; + public static final String FOOTER_KEY_PROPERTY_NAME = "encryption.footer.key"; + public static final String ENCRYPTION_ALGORITHM_PROPERTY_NAME = "encryption.algorithm"; + public static final String PLAINTEXT_FOOTER_PROPERTY_NAME = "encryption.plaintext.footer"; + + public static final int DEK_LENGTH = 16; + + private static final SecureRandom random = new SecureRandom(); + + @Override + public FileEncryptionProperties getFileEncryptionProperties(Configuration fileHadoopConfig, Path tempFilePath, + WriteContext fileWriteContext) throws ParquetCryptoRuntimeException { + + String footerKeyId = fileHadoopConfig.getTrimmed(FOOTER_KEY_PROPERTY_NAME); + String columnKeysStr = fileHadoopConfig.getTrimmed(COLUMN_KEYS_PROPERTY_NAME); + + // File shouldn't be encrypted + if (stringIsEmpty(footerKeyId) && stringIsEmpty(columnKeysStr)) { + return null; + } + + if (stringIsEmpty(footerKeyId)) { + throw new ParquetCryptoRuntimeException("Undefined footer key"); + } + + FileKeyMaterialStore keyMaterialStore = null; + boolean keyMaterialInternalStorage = fileHadoopConfig.getBoolean(KeyToolkit.KEY_MATERIAL_INTERNAL_PROPERTY_NAME, true); Review comment: In this particular case, the properties is used twice is two independent paths - file write path (get encryption properties), and file read path (get decryption properties). But we can use a const (final bool) for its default value. And will check other properties. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
