gszadovszky commented on a change in pull request #832:
URL: https://github.com/apache/parquet-mr/pull/832#discussion_r562061225
##########
File path:
parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java
##########
@@ -325,7 +323,7 @@ private ConvertedField visitPrimitiveType(PrimitiveTypeName
type, LogicalTypeAnn
@Override
public ConvertedField visit(EnumType enumType, State state) {
- return visitPrimitiveType(BINARY, enumType(), state);
+ return visitPrimitiveType(BINARY, LogicalTypeAnnotation.enumType(), state);
Review comment:
Yes, I know what this PR is about. My comment was only about this line
(and the removing of the static import).
It is a matter of taste whether you like static imports or not and it is up
to you if you use them or not. But modifying an existing line is another topic.
I usually like to keep a change as small as possible and do not touch other
code parts if it is not necessary.
Anyway, if you have a strong opinion that this change improves readability I
am fine with that too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
