jmartone commented on a change in pull request #832:
URL: https://github.com/apache/parquet-mr/pull/832#discussion_r562035955
##########
File path:
parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java
##########
@@ -325,7 +323,7 @@ private ConvertedField visitPrimitiveType(PrimitiveTypeName
type, LogicalTypeAnn
@Override
public ConvertedField visit(EnumType enumType, State state) {
- return visitPrimitiveType(BINARY, enumType(), state);
+ return visitPrimitiveType(BINARY, LogicalTypeAnnotation.enumType(), state);
Review comment:
I find accessing these via `LogicalTypeAnnotation.enumType()` more clear
than just `enumType()`. The larger change in this PR allows any thrift type to
use a LogicalTypeAnnotation, so importing the class opens the door to further
changes that implement these logical types.
##########
File path:
parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java
##########
@@ -325,7 +323,7 @@ private ConvertedField visitPrimitiveType(PrimitiveTypeName
type, LogicalTypeAnn
@Override
public ConvertedField visit(EnumType enumType, State state) {
- return visitPrimitiveType(BINARY, enumType(), state);
+ return visitPrimitiveType(BINARY, LogicalTypeAnnotation.enumType(), state);
Review comment:
I remove this static import for consistency with the logical types in my
changes. I do find qualifying the type with `LogicalTypeAnnotation.` improves
readability.
If we prefer a set of discrete static imports to importing the larger class
I can certainly do that instead. My motivation was more concise imports and
readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
