theosib-amazon commented on code in PR #960:
URL: https://github.com/apache/parquet-mr/pull/960#discussion_r934627078
##########
parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java:
##########
@@ -38,6 +39,34 @@ class SingleBufferInputStream extends ByteBufferInputStream {
// duplicate the buffer because its state will be modified
this.buffer = buffer.duplicate();
this.startPosition = buffer.position();
+ this.buffer.order(java.nio.ByteOrder.LITTLE_ENDIAN);
+ }
+
+ SingleBufferInputStream(ByteBuffer buffer, int start, int length) {
+ // duplicate the buffer because its state will be modified
+ this.buffer = buffer.duplicate();
+ this.startPosition = start;
+ this.buffer.position(start);
+ this.buffer.limit(start + length);
+ this.buffer.order(java.nio.ByteOrder.LITTLE_ENDIAN);
+ }
+
+ SingleBufferInputStream(byte[] inBuf) {
+ this.buffer = ByteBuffer.wrap(inBuf);
+ this.buffer.order(java.nio.ByteOrder.LITTLE_ENDIAN);
+ this.startPosition = 0;
+ }
+
+ SingleBufferInputStream(byte[] inBuf, int start, int length) {
+ this.buffer = ByteBuffer.wrap(inBuf, start, length);
+ this.buffer.order(java.nio.ByteOrder.LITTLE_ENDIAN);
+ // This seems to be consistent with HeapByteBuffer.wrap(), which leaves
+ // the internal "offset" at zero and sets the starting position at start.
+ this.startPosition = 0;
+ }
+
+ SingleBufferInputStream(List<ByteBuffer> inBufs) {
Review Comment:
IIRC, I used to have a similar constructor for ByteBufferInputStream, but I
was advised to remove it, so I had this here for uniformity. We can remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
