theosib-amazon commented on code in PR #960:
URL: https://github.com/apache/parquet-mr/pull/960#discussion_r934648806
##########
parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java:
##########
@@ -88,6 +136,21 @@ public long skip(long n) {
return bytesToSkip;
}
+ @Override
+ public void skipFully(long n) throws IOException {
+ if (n < 0 || n > Integer.MAX_VALUE) {
+ throw new IllegalArgumentException();
Review Comment:
got it
##########
parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java:
##########
@@ -70,9 +105,22 @@ public int read(byte[] bytes, int offset, int length)
throws IOException {
return bytesToRead;
}
-
+
+ @Override
+ public void readFully(byte[] bytes, int offset, int length) throws
IOException {
+ try {
+ buffer.get(bytes, offset, length);
+ } catch (BufferUnderflowException|IndexOutOfBoundsException e) {
+ throw new EOFException(e.getMessage());
+ }
+ }
+
@Override
public long skip(long n) {
+ if (n < 0) {
+ throw new IllegalArgumentException();
Review Comment:
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
