wgtmac commented on code in PR #1023: URL: https://github.com/apache/parquet-mr/pull/1023#discussion_r1102205460
########## parquet-hadoop/src/main/java/org/apache/parquet/filter2/compat/PredicateEvaluation.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.parquet.filter2.compat; + +import org.apache.parquet.filter2.predicate.FilterPredicate; +import org.apache.parquet.filter2.predicate.Operators; + +/** + * Used in Filters to mark whether the block data matches the condition. + * If we cannot decide whether the block matches, it will be always safe to return BLOCK_MIGHT_MATCH. + * + * We use Boolean Object here to distinguish the value type, please do not modify it. + */ +public class PredicateEvaluation { + /* The block might match, but we cannot decide yet, will check in the other filters. */ + public static final Boolean BLOCK_MIGHT_MATCH = new Boolean(false); + /* The block can match for sure. */ + public static final Boolean BLOCK_MUST_MATCH = new Boolean(false); + /* The block can't match for sure */ + public static final Boolean BLOCK_CANNOT_MATCH = new Boolean(true); + + public static Boolean evaluateAnd(Operators.And and, FilterPredicate.Visitor<Boolean> predicate) { + Boolean left = and.getLeft().accept(predicate); + Boolean right = and.getRight().accept(predicate); + if (left == BLOCK_CANNOT_MATCH || right == BLOCK_CANNOT_MATCH) { + return BLOCK_CANNOT_MATCH; + } else if (left == BLOCK_MUST_MATCH && right == BLOCK_MUST_MATCH) { + // if left and right operation must need the block, then we must take the block + return BLOCK_MUST_MATCH; + } else { + return BLOCK_MIGHT_MATCH; + } + } + + public static Boolean evaluateOr(Operators.Or or, FilterPredicate.Visitor<Boolean> predicate) { + Boolean left = or.getLeft().accept(predicate); + Boolean right = or.getRight().accept(predicate); + if (left == BLOCK_CANNOT_MATCH && right == BLOCK_CANNOT_MATCH) { + return BLOCK_CANNOT_MATCH; + } else if (left == BLOCK_MUST_MATCH || right == BLOCK_MUST_MATCH) { + // if left or right operation must need the block, then we must take the block + return BLOCK_MUST_MATCH; + } else { + return BLOCK_MIGHT_MATCH; + } + } + + public static Boolean isDeterminedPredicate(Boolean predicate) { + return predicate == BLOCK_MUST_MATCH || predicate == BLOCK_CANNOT_MATCH; + } + + public static void checkPredicate(Boolean predicate) { Review Comment: ```suggestion public static void checkPredicate(boolean predicate) { ``` ########## parquet-hadoop/src/main/java/org/apache/parquet/filter2/compat/PredicateEvaluation.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.parquet.filter2.compat; + +import org.apache.parquet.filter2.predicate.FilterPredicate; +import org.apache.parquet.filter2.predicate.Operators; + +/** + * Used in Filters to mark whether the block data matches the condition. + * If we cannot decide whether the block matches, it will be always safe to return BLOCK_MIGHT_MATCH. + * + * We use Boolean Object here to distinguish the value type, please do not modify it. + */ +public class PredicateEvaluation { + /* The block might match, but we cannot decide yet, will check in the other filters. */ + public static final Boolean BLOCK_MIGHT_MATCH = new Boolean(false); + /* The block can match for sure. */ + public static final Boolean BLOCK_MUST_MATCH = new Boolean(false); + /* The block can't match for sure */ + public static final Boolean BLOCK_CANNOT_MATCH = new Boolean(true); + + public static Boolean evaluateAnd(Operators.And and, FilterPredicate.Visitor<Boolean> predicate) { + Boolean left = and.getLeft().accept(predicate); + Boolean right = and.getRight().accept(predicate); + if (left == BLOCK_CANNOT_MATCH || right == BLOCK_CANNOT_MATCH) { + return BLOCK_CANNOT_MATCH; + } else if (left == BLOCK_MUST_MATCH && right == BLOCK_MUST_MATCH) { + // if left and right operation must need the block, then we must take the block + return BLOCK_MUST_MATCH; + } else { + return BLOCK_MIGHT_MATCH; + } + } + + public static Boolean evaluateOr(Operators.Or or, FilterPredicate.Visitor<Boolean> predicate) { + Boolean left = or.getLeft().accept(predicate); + Boolean right = or.getRight().accept(predicate); + if (left == BLOCK_CANNOT_MATCH && right == BLOCK_CANNOT_MATCH) { + return BLOCK_CANNOT_MATCH; + } else if (left == BLOCK_MUST_MATCH || right == BLOCK_MUST_MATCH) { + // if left or right operation must need the block, then we must take the block + return BLOCK_MUST_MATCH; + } else { + return BLOCK_MIGHT_MATCH; + } + } + + public static Boolean isDeterminedPredicate(Boolean predicate) { + return predicate == BLOCK_MUST_MATCH || predicate == BLOCK_CANNOT_MATCH; + } + + public static void checkPredicate(Boolean predicate) { Review Comment: If `BLOCK_CANNOT_MATCH` is defined as `Boolean` but not as `boolean`, the equality check here may fail if the input predicate is created in other places. Either replace `==` with `.equals()` or use `boolean` as your choice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
