pitrou commented on PR #193:
URL: https://github.com/apache/parquet-format/pull/193#issuecomment-1474171946

   Ok, so v2 data pages for RLE-encoded boolean do encode the length:
   
https://github.com/apache/parquet-mr/blob/1235003e742e6a76bf6cb8f7ed33e942fa12d0d5/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV2ValuesWriterFactory.java#L77-L80
   
   However, I don't think that RLE-encoded dictionary indices encode the length:
   
https://github.com/apache/parquet-mr/blob/1235003e742e6a76bf6cb8f7ed33e942fa12d0d5/parquet-column/src/main/java/org/apache/parquet/column/values/dictionary/DictionaryValuesWriter.java#L161-L162
   
   ... because `RunLengthBitPackingHybridValuesWriter` prepends the length, but 
`RunLengthBitPackingHybridEncoder` doesn't:
   
https://github.com/apache/parquet-mr/blob/1235003e742e6a76bf6cb8f7ed33e942fa12d0d5/parquet-column/src/main/java/org/apache/parquet/column/values/rle/RunLengthBitPackingHybridValuesWriter.java#L68-L70
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to