[ 
https://issues.apache.org/jira/browse/PDFBOX-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446840#comment-16446840
 ] 

Tilman Hausherr edited comment on PDFBOX-4189 at 4/22/18 6:35 AM:
------------------------------------------------------------------

Thank you [~paawak] I committed your code with slight modifications. I removed 
most formatting changes (it drives the attention away from the acual changes) 
and changed the example code as mentioned before.

todo next:
- [~amake] please use the trunk to check if your vertical texts are still ok 
(likely yes, the tests pass and the PDF generated by the sample works too)
- [~paawak] the example output now looks even more different than before - or 
is the text from the screenshot wrong? Is this related to your latest change, 
or could it be I messed up something?
- run sonar tool (done)
- implement something to activate language specific handling
- port to 2.0 after a few days



was (Author: tilman):
Thank you [~paawak] I committed your code with slight modifications. I removed 
most formatting changes (it drives the attention away from the acual changes) 
and changed the example code as mentioned before.

todo next:
- [~amake] please use the trunk to check if your vertical texts are still ok 
(likely yes, the tests pass and the PDF generated by the sample works too)
- [~paawak] the example output now looks even more different than before - or 
is the text from the screenshot wrong? Is this related to your latest change, 
or could it be I messed up something?
- run sonar tool
- port to 2.0 after a few days


> Enable PDF creation with Indian languages, by reading and utilizing the GSUB 
> table
> ----------------------------------------------------------------------------------
>
>                 Key: PDFBOX-4189
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4189
>             Project: PDFBox
>          Issue Type: New Feature
>          Components: FontBox, PDModel
>            Reporter: Palash Ray
>            Priority: Major
>         Attachments: Bengali-text-after.pdf, Bengali-text-before.pdf, 
> BengaliPdfGenerationHelloWorld.java, bengali-example.pdf, 
> bengali-example2.pdf, committed.patch, screenshot.png
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Implemented proper rendering of Indian languages, which need extensive Glyph 
> substitution. The GSUB table has been read and used effectively to replace 
> some compound words with their respective Glyphs. All tests are passing. I 
> have tested this for the Bengali font. Please review these changes and let me 
> know if it makes sense to incorporate these.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to