[
https://issues.apache.org/jira/browse/PDFBOX-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454699#comment-16454699
]
Palash Ray edited comment on PDFBOX-4189 at 4/26/18 7:03 PM:
-------------------------------------------------------------
Well, I share your concern of not impacting others with these Gsub changes. I
have a safety feature here: unless your Font supports the specific script name
mentioned in the Language enum, this Gsub system will not kick in. And right
now I have only the Bengali language in the Language enum. I think due to this
safety feature, the Gsub feature should be pretty safe to have. However, if you
find some other vulnerability that I might have overlooked, please do let me
know, I am more than happy to fix.
As for the Gsub workers, Tilman, I have taken your advice and created a Map of
GsubWorkers. Please take a look if that agrees with you:
[https://github.com/apache/pdfbox/pull/49]
Thanks,
Palash.
was (Author: paawak):
Well, I share your concern of not impacting others with these Gsub changes. I
have a safety feature here: unless your Font supports the specific script name
mentioned in the Language enum, this Gsub system will not kick in. And right
now I have only the Bengali language in the Language enum. I think due o this
safety feature, this Gsub feature should be pretty safe to have. However, if
you find some other vulnerability that I might have overlooked, please do let
me know, I am more than happy to fix them.
As for the Gsub workers, Tilman, I have taken your advice and created a Map of
GsubWorkers. Please take a look if that agrees with you:
[https://github.com/apache/pdfbox/pull/49]
Thanks,
Palash.
> Enable PDF creation with Indian languages, by reading and utilizing the GSUB
> table
> ----------------------------------------------------------------------------------
>
> Key: PDFBOX-4189
> URL: https://issues.apache.org/jira/browse/PDFBOX-4189
> Project: PDFBox
> Issue Type: New Feature
> Components: FontBox, PDModel
> Reporter: Palash Ray
> Priority: Major
> Attachments: Bengali-text-after.pdf, Bengali-text-before.pdf,
> BengaliPdfGenerationHelloWorld.java, bengali-example.pdf,
> bengali-example2.pdf, committed.patch, screenshot.png
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Implemented proper rendering of Indian languages, which need extensive Glyph
> substitution. The GSUB table has been read and used effectively to replace
> some compound words with their respective Glyphs. All tests are passing. I
> have tested this for the Bengali font. Please review these changes and let me
> know if it makes sense to incorporate these.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
