[
https://issues.apache.org/jira/browse/PDFBOX-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453042#comment-16453042
]
Tilman Hausherr edited comment on PDFBOX-4189 at 4/25/18 8:33 PM:
------------------------------------------------------------------
With "same as 2.0.9 i.e. no rearrangement" I mean that the new feature should
not be activated by default, so that people who use 2.0.10 (assuming I commit
your changes there too) would have the same output as before. The reason is
that not everybody wants this, for example people who have pixel comparisons of
their output don't want their tests to fail after a version change because of
the rearrangement / replacement.
About activating the script - I think it should be independent of the font.
Some fonts may support several scripts. (I just see that your gsubdata code
returns one single language so maybe I'm wrong there, I thought of Arial Uni
that has a lot of different alphabets)
How about caching the workers in the content stream, with the font as the key?
was (Author: tilman):
With "same as 2.0.9 i.e. no rearrangement" I mean that the new feature should
not be activated by default, so that people who use 2.0.10 (assuming I commit
your changes there too) would have the same output as before. The reason is
that not everybody wants this, for example people who have pixel comparisons of
their output don't want their tests to fail after a version change because of
the rearrangement / replacement.
About activating the script - I think it should be independent of the font.
Some fonts may support several scripts. (I just see that your gsubdata code
returns one single language so maybe I'm wrong there, I thought of Arial Uni
that has a lot of different languages)
How about caching the workers in the content stream, with the font as the key?
> Enable PDF creation with Indian languages, by reading and utilizing the GSUB
> table
> ----------------------------------------------------------------------------------
>
> Key: PDFBOX-4189
> URL: https://issues.apache.org/jira/browse/PDFBOX-4189
> Project: PDFBox
> Issue Type: New Feature
> Components: FontBox, PDModel
> Reporter: Palash Ray
> Priority: Major
> Attachments: Bengali-text-after.pdf, Bengali-text-before.pdf,
> BengaliPdfGenerationHelloWorld.java, bengali-example.pdf,
> bengali-example2.pdf, committed.patch, screenshot.png
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Implemented proper rendering of Indian languages, which need extensive Glyph
> substitution. The GSUB table has been read and used effectively to replace
> some compound words with their respective Glyphs. All tests are passing. I
> have tested this for the Bengali font. Please review these changes and let me
> know if it makes sense to incorporate these.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
