So in my case I altered build.sbt in order to add ThisBuild / version := "1.0.0-RC2"
to it (didn't need to set `isSnapshot := false`). afaik isSnapshot is just checking if the version ends in `-SNAPSHOT` . I think there is an issue with sbt's value overriding if you do sbt "set ThisBuild / version := \"1.0.0-RC2\"; +publishSigned" as documented in https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process#deploy-the-jars-to-apache-maven-repository-staging Let me verify this On Wed, Jul 26, 2023 at 6:55 PM Johannes Rudolph <[email protected]> wrote: > I had to set `ThisBuild / isSnapshot := false` to generate the same > result. > > On Wed, Jul 26, 2023 at 6:40 PM Matthew de Detrich > <[email protected]> wrote: > > > > So this is the part of the build that can cause this problem > > > https://github.com/apache/incubator-pekko-http/blob/f6f0a3632a3a52cd8a177a0beeb6704dd22347b1/build.sbt#L27 > > . Maybe the sbt version was not set correctly when publishing the jars? > > > > On Wed, Jul 26, 2023 at 6:33 PM Matthew de Detrich < > > [email protected]> wrote: > > > > > I managed to find a difference between my own local build (I checked > out > > > the v1.0.0-RC2 tag pointing to > 37f35d6bccd9913c6dd108004581a9abcb91343e). > > > The bytecode in the JARs are the same however the POM's differ. For > example > > > with pekko-parsing_2.12.pom the staging version has > > > > > > <info.apiURL>https://pekko.apache.org/api/pekko-http/current/ > > > </info.apiURL> > > > > > > where as my version has > > > > > > <info.apiURL>https://pekko.apache.org/api/pekko-http/1.0.0-RC2/ > > > </info.apiURL> > > > > > > You can view the diff online at https://www.diffchecker.com/fgbLmaY8/ > . > > > > > > Are you sure you had the correct git tag checked out when making the > build? > > > > > > On Wed, Jul 26, 2023 at 2:57 PM Johannes Rudolph < > > > [email protected]> wrote: > > > > > >> Thanks for running the release again, PJ! > > >> > > >> I went through the checklist and everything was fine. Additionally, I > > >> checked locally built 2.13 and 2.12 binaries against the published > > >> ones. > > >> > > >> +1 > > >> > > >> Johannes > > >> > > >> > > >> > > >> > > >> On Wed, Jul 26, 2023 at 12:23 PM PJ Fanning <[email protected]> > wrote: > > >> > > > >> > Hello Pekko Community, > > >> > > > >> > This is a call for a vote to release Apache Pekko(incubating) HTTP > > >> > version 1.0.0-RC2. > > >> > > > >> > The discussion thread: > > >> > > > >> > https://lists.apache.org/thread/ogfbr3g2otd35gjct06bj2ll5lbh8bzd > > >> > > > >> > The release candidate: > > >> > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/pekko/HTTP-1.0.0-RC2/ > > >> > > > >> > This release has been signed with a PGP key available here: > > >> > > > >> > https://dist.apache.org/repos/dist/dev/incubator/pekko/KEYS > > >> > > > >> > Release Notes: > > >> > > > >> > > > >> > https://pekko.apache.org/docs/pekko-http/current/release-notes/index.html > > >> > > > >> > Git branch for the release: > > >> > > > >> > https://github.com/apache/incubator-pekko-http/tree/v1.0.0-RC2 > > >> > Git commit ID: 37f35d6bccd9913c6dd108004581a9abcb91343e > > >> > > > >> > Please download, verify, and test. > > >> > > > >> > We have also staged jars in the Apache Nexus Repository. These were > > >> > built with the same code > > >> > as appears in this Source Release Candidate. We would appreciate if > > >> > users could test with these too. > > >> > If anyone finds any serious problems with these jars, please also > > >> > notify us on this thread. > > >> > > > >> > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > >> > > > >> > In sbt, you can add this resolver. > > >> > > > >> > resolvers += "Apache Pekko Staging" at > > >> > "https://repository.apache.org/content/groups/staging"; > > >> > > > >> > > > >> > The VOTE will pass if we have more positive votes than negative > votes > > >> > and there must be a minimum of 3 approvals from Pekko PPMC members. > > >> > Anyone voting in favour of the release, could you please provide a > > >> > list of the checks you have done? > > >> > The vote will be left open until 11:00 UTC on 29 July 2023. > > >> > > > >> > [ ] +1 approve > > >> > [ ] +0 no opinion > > >> > [ ] -1 disapprove with the reason > > >> > > > >> > To learn more about Apache Pekko, please see > https://pekko.apache.org/ > > >> > > > >> > Checklist for reference: > > >> > > > >> > [ ] Download links are valid. > > >> > [ ] Checksums and signatures. > > >> > [ ] LICENSE/NOTICE files exist > > >> > [ ] No unexpected binary files > > >> > [ ] All source files have ASF headers > > >> > [ ] Can compile from source > > >> > > > >> > To compile from the source, please refer to: > > >> > > > >> > > > >> > https://github.com/apache/incubator-pekko-http/blob/main/README.md#building-from-source > > >> > > > >> > Some notes about verifying downloads can be found at: > > >> > > > >> > https://pekko.apache.org/download.html#verifying-downloads > > >> > > > >> > > > >> > Here is my +1. > > >> > > > >> > Thanks, > > >> > > > >> > PJ Fanning (Apache Pekko PPMC member) > > >> > > > >> > > --------------------------------------------------------------------- > > >> > To unsubscribe, e-mail: [email protected] > > >> > For additional commands, e-mail: [email protected] > > >> > > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [email protected] > > >> For additional commands, e-mail: [email protected] > > >> > > >> > > > > > > -- > > > > > > Matthew de Detrich > > > > > > *Aiven Deutschland GmbH* > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > *m:* +491603708037 > > > > > > *w:* aiven.io *e:* [email protected] > > > > > > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* [email protected] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
