So what I can say is that from the getgo, if you are checked at a git tag (i.e. git checkout v1.0.0-RC2) then everything should be set correctly, i.e.
<@incubator-pekko-http>-<⎇ 37f35d6bc>-<*>-> git checkout v1.0.0-RC2 HEAD is now at 37f35d6bc pekko 1.0.1 (#270) <@incubator-pekko-http>-<⎇ 37f35d6bc>-<*>-> sbt [info] welcome to sbt 1.9.2 (Homebrew Java 11.0.20) [info] loading global plugins from /Users/mdedetrich/.sbt/1.0/plugins [info] loading settings for project incubator-pekko-http-build from plugins.sbt ... [info] loading project definition from /Users/mdedetrich/github/incubator-pekko-http/project [info] loading settings for project pekko-http from build.sbt ... [info] resolving key references (34555 settings) ... [info] Building Pekko HTTP 1.0.0-RC2 against Pekko 1.0.1 on Scala 2.13.11 [info] set current project to pekko-http-root (in build file:/Users/mdedetrich/github/incubator-pekko-http/) [warn] there's a key that's not used by any other settings/tasks: [warn] [warn] * ThisBuild / projectInfoVersion [warn] +- /Users/mdedetrich/github/incubator-pekko-http/build.sbt:25 [warn] [warn] note: a setting might still be used by a command; to exclude a key from this `lintUnused` check [warn] either append it to `Global / excludeLintKeys` or call .withRank(KeyRanks.Invisible) on the key [info] sbt server started at local:///Users/mdedetrich/.sbt/1.0/server/aaf3ddd85825edcaffeb/sock [info] started sbt server pekko-http > isSnapshot [info] http-caching / isSnapshot [info] false [info] http-jackson / isSnapshot [info] false [info] http-marshallers-java / isSnapshot [info] false [info] http-spray-json / isSnapshot [info] false [info] http-xml / isSnapshot [info] false [info] http-marshallers-scala / isSnapshot [info] false [info] http-cors / isSnapshot [info] false [info] http / isSnapshot [info] false [info] bill-of-materials / isSnapshot [info] false [info] http-bench-jmh / isSnapshot [info] false [info] http-core / isSnapshot [info] false [info] http-tests / isSnapshot [info] false [info] parsing / isSnapshot [info] false [info] http-scalafix-rules / isSnapshot [info] false [info] http2-tests / isSnapshot [info] false [info] http-testkit / isSnapshot [info] false [info] docs / isSnapshot [info] false [info] isSnapshot [info] false pekko-http > version [info] http-caching / version [info] 1.0.0-RC2 [info] http-jackson / version [info] 1.0.0-RC2 [info] http-marshallers-java / version [info] 1.0.0-RC2 [info] http-spray-json / version [info] 1.0.0-RC2 [info] http-xml / version [info] 1.0.0-RC2 [info] http-marshallers-scala / version [info] 1.0.0-RC2 [info] http-cors / version [info] 1.0.0-RC2 [info] http / version [info] 1.0.0-RC2 [info] bill-of-materials / version [info] 1.0.0-RC2 [info] http-bench-jmh / Jmh / version [info] 1.32 [info] http-core / version [info] 1.0.0-RC2 [info] http-tests / version [info] 1.0.0-RC2 [info] parsing / version [info] 1.0.0-RC2 [info] http-scalafix-rules / version [info] 1.0.0-RC2 [info] http2-tests / version [info] 1.0.0-RC2 [info] http-testkit / version [info] 1.0.0-RC2 [info] docs / version [info] 1.0.0-RC2 [info] version [info] 1.0.0-RC2 pekko-http > I think this may occur if you are building off the source dist and/or checkout out the git reference directly without using git checkout <TAG> (i.e. in this case git checkout 37f35d6bccd9913c6dd108004581a9abcb91343e). In my case I always checkout the git tag and make sure that the git tags are up to date beforehand, i.e. git fetch upstream (which retrieves latest tags) On Wed, Jul 26, 2023 at 7:02 PM Matthew de Detrich < [email protected]> wrote: > So in my case I altered build.sbt in order to add > > ThisBuild / version := "1.0.0-RC2" > > to it (didn't need to set `isSnapshot := false`). afaik isSnapshot is just > checking if the version ends in `-SNAPSHOT` . I think there is an issue > with sbt's value overriding if you do > > sbt "set ThisBuild / version := \"1.0.0-RC2\"; +publishSigned" > > as documented in > https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process#deploy-the-jars-to-apache-maven-repository-staging > > Let me verify this > > On Wed, Jul 26, 2023 at 6:55 PM Johannes Rudolph < > [email protected]> wrote: > >> I had to set `ThisBuild / isSnapshot := false` to generate the same >> result. >> >> On Wed, Jul 26, 2023 at 6:40 PM Matthew de Detrich >> <[email protected]> wrote: >> > >> > So this is the part of the build that can cause this problem >> > >> https://github.com/apache/incubator-pekko-http/blob/f6f0a3632a3a52cd8a177a0beeb6704dd22347b1/build.sbt#L27 >> > . Maybe the sbt version was not set correctly when publishing the jars? >> > >> > On Wed, Jul 26, 2023 at 6:33 PM Matthew de Detrich < >> > [email protected]> wrote: >> > >> > > I managed to find a difference between my own local build (I checked >> out >> > > the v1.0.0-RC2 tag pointing to >> 37f35d6bccd9913c6dd108004581a9abcb91343e). >> > > The bytecode in the JARs are the same however the POM's differ. For >> example >> > > with pekko-parsing_2.12.pom the staging version has >> > > >> > > <info.apiURL>https://pekko.apache.org/api/pekko-http/current/ >> > > </info.apiURL> >> > > >> > > where as my version has >> > > >> > > <info.apiURL>https://pekko.apache.org/api/pekko-http/1.0.0-RC2/ >> > > </info.apiURL> >> > > >> > > You can view the diff online at https://www.diffchecker.com/fgbLmaY8/ >> . >> > > >> > > Are you sure you had the correct git tag checked out when making the >> build? >> > > >> > > On Wed, Jul 26, 2023 at 2:57 PM Johannes Rudolph < >> > > [email protected]> wrote: >> > > >> > >> Thanks for running the release again, PJ! >> > >> >> > >> I went through the checklist and everything was fine. Additionally, I >> > >> checked locally built 2.13 and 2.12 binaries against the published >> > >> ones. >> > >> >> > >> +1 >> > >> >> > >> Johannes >> > >> >> > >> >> > >> >> > >> >> > >> On Wed, Jul 26, 2023 at 12:23 PM PJ Fanning <[email protected]> >> wrote: >> > >> > >> > >> > Hello Pekko Community, >> > >> > >> > >> > This is a call for a vote to release Apache Pekko(incubating) HTTP >> > >> > version 1.0.0-RC2. >> > >> > >> > >> > The discussion thread: >> > >> > >> > >> > https://lists.apache.org/thread/ogfbr3g2otd35gjct06bj2ll5lbh8bzd >> > >> > >> > >> > The release candidate: >> > >> > >> > >> > >> https://dist.apache.org/repos/dist/dev/incubator/pekko/HTTP-1.0.0-RC2/ >> > >> > >> > >> > This release has been signed with a PGP key available here: >> > >> > >> > >> > https://dist.apache.org/repos/dist/dev/incubator/pekko/KEYS >> > >> > >> > >> > Release Notes: >> > >> > >> > >> > >> > >> >> https://pekko.apache.org/docs/pekko-http/current/release-notes/index.html >> > >> > >> > >> > Git branch for the release: >> > >> > >> > >> > https://github.com/apache/incubator-pekko-http/tree/v1.0.0-RC2 >> > >> > Git commit ID: 37f35d6bccd9913c6dd108004581a9abcb91343e >> > >> > >> > >> > Please download, verify, and test. >> > >> > >> > >> > We have also staged jars in the Apache Nexus Repository. These were >> > >> > built with the same code >> > >> > as appears in this Source Release Candidate. We would appreciate if >> > >> > users could test with these too. >> > >> > If anyone finds any serious problems with these jars, please also >> > >> > notify us on this thread. >> > >> > >> > >> > >> https://repository.apache.org/content/groups/staging/org/apache/pekko/ >> > >> > >> > >> > In sbt, you can add this resolver. >> > >> > >> > >> > resolvers += "Apache Pekko Staging" at >> > >> > "https://repository.apache.org/content/groups/staging"; >> > >> > >> > >> > >> > >> > The VOTE will pass if we have more positive votes than negative >> votes >> > >> > and there must be a minimum of 3 approvals from Pekko PPMC members. >> > >> > Anyone voting in favour of the release, could you please provide a >> > >> > list of the checks you have done? >> > >> > The vote will be left open until 11:00 UTC on 29 July 2023. >> > >> > >> > >> > [ ] +1 approve >> > >> > [ ] +0 no opinion >> > >> > [ ] -1 disapprove with the reason >> > >> > >> > >> > To learn more about Apache Pekko, please see >> https://pekko.apache.org/ >> > >> > >> > >> > Checklist for reference: >> > >> > >> > >> > [ ] Download links are valid. >> > >> > [ ] Checksums and signatures. >> > >> > [ ] LICENSE/NOTICE files exist >> > >> > [ ] No unexpected binary files >> > >> > [ ] All source files have ASF headers >> > >> > [ ] Can compile from source >> > >> > >> > >> > To compile from the source, please refer to: >> > >> > >> > >> > >> > >> >> https://github.com/apache/incubator-pekko-http/blob/main/README.md#building-from-source >> > >> > >> > >> > Some notes about verifying downloads can be found at: >> > >> > >> > >> > https://pekko.apache.org/download.html#verifying-downloads >> > >> > >> > >> > >> > >> > Here is my +1. >> > >> > >> > >> > Thanks, >> > >> > >> > >> > PJ Fanning (Apache Pekko PPMC member) >> > >> > >> > >> > >> --------------------------------------------------------------------- >> > >> > To unsubscribe, e-mail: [email protected] >> > >> > For additional commands, e-mail: [email protected] >> > >> > >> > >> >> > >> --------------------------------------------------------------------- >> > >> To unsubscribe, e-mail: [email protected] >> > >> For additional commands, e-mail: [email protected] >> > >> >> > >> >> > > >> > > -- >> > > >> > > Matthew de Detrich >> > > >> > > *Aiven Deutschland GmbH* >> > > >> > > Immanuelkirchstraße 26, 10405 Berlin >> > > >> > > Amtsgericht Charlottenburg, HRB 209739 B >> > > >> > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > > >> > > *m:* +491603708037 >> > > >> > > *w:* aiven.io *e:* [email protected] >> > > >> > >> > >> > -- >> > >> > Matthew de Detrich >> > >> > *Aiven Deutschland GmbH* >> > >> > Immanuelkirchstraße 26, 10405 Berlin >> > >> > Amtsgericht Charlottenburg, HRB 209739 B >> > >> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > >> > *m:* +491603708037 >> > >> > *w:* aiven.io *e:* [email protected] >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* [email protected] > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
