Okay it is indeed only used in docs so no need to make a new release candidate, @PJ Fanning <[email protected]> can you re-run the CI job (the PR was just merged into main). I will check RC1 later tonight.
On Sun, Oct 29, 2023 at 11:11 AM Matthew de Detrich < [email protected]> wrote: > Let me double check that indeed those values are only used for doc > publishing and not something more critical (i.e. POM fields). > > On Sun, Oct 29, 2023 at 11:06 AM PJ Fanning <[email protected]> wrote: > >> The doc publishing is independent of the RCs. I can just rerun the CI job. >> >> >> https://github.com/apache/incubator-pekko-connectors/actions/workflows/publish-1.0-docs.yml >> >> I've started a new run, now that the PR is merged. >> >> I still don't see why this forces us to abandon RC1 and do an RC2. >> >> On Sun, 29 Oct 2023 at 09:59, Matthew de Detrich >> <[email protected]> wrote: >> > >> > > In our pekko.apache.org docs `current` and `1.0` both redirect to the >> > same pages. I don't see why >> > https://github.com/apache/incubator-pekko-connectors/pull/271 is a >> > release blocker. >> > >> > There is a reason why there are comments in the Pekko Connectors (i.e. >> > >> https://github.com/apache/incubator-pekko-connectors/blob/b4884fa64dac6f66e3cf758f0e42948f7202dfb9/project/plugins.sbt#L39 >> > and >> > >> https://github.com/apache/incubator-pekko-connectors/blob/7c04bed348f405570c7db3e4aedd063cd2fbd23f/project/Dependencies.scala#L32 >> ) >> > that say the version have to be in sync, >> > its because current will diverge over time (by definition its mutable). >> > >> > > If we do block the RC1 over this then we need an RC2. We can't rewrite >> > history. >> > >> > Is it a big problem to do this? I would actually prefer it if its in >> 1.0.1 >> > for the reasons I stated. Our bottleneck is not in setting up releases, >> > its in getting them over the finish line and I would volunteer to step >> up >> > to do the next RC if there is a problem (I was just >> > really busy this week and didn't have much time to properly look over >> > things, next week should be a bit better). >> > >> > On Sun, Oct 29, 2023 at 10:52 AM PJ Fanning <[email protected]> >> wrote: >> > >> > > In our pekko.apache.org docs `current` and `1.0` both redirect to the >> > > same pages. I don't see why >> > > https://github.com/apache/incubator-pekko-connectors/pull/271 is a >> > > release blocker. I'm happy to have it merged but it does not affect >> > > real users of Pekko today. It will only affect users once we start >> > > releasing 1.1.x releases. >> > > >> > > If we do block the RC1 over this then we need an RC2. We can't rewrite >> > > history. >> > > >> > > On Sun, 29 Oct 2023 at 09:17, Matthew de Detrich >> > > <[email protected]> wrote: >> > > > >> > > > Sorry to do this, but there is one regression we did when setting >> the >> > > > versioning (see >> > > > https://github.com/apache/incubator-pekko-connectors/pull/271) and >> I >> > > would >> > > > like to get this into the release especially considering how >> difficult it >> > > > has been to get releases out. >> > > > >> > > > It might be possible to re-trigger the vote for connectors if >> possible >> > > > since no one has voted, we would have to get INFRA to delete the >> > > v1.0.1-RC1 >> > > > tag for us (since we would have to recreate the tag) but they are >> usually >> > > > very quick to do this? Otherwise we can just increment the RC (i.e. >> > > > v1.0.1-RC2). >> > > > >> > > > On Sat, Oct 28, 2023 at 3:58 PM PJ Fanning <[email protected]> >> wrote: >> > > > >> > > > > Hello Pekko Community, >> > > > > >> > > > > This is a call for a vote to release Apache Pekko(incubating) >> > > > > Connectors version 1.0.1-RC1. >> > > > > >> > > > > The discussion thread: >> > > > > >> > > > > https://lists.apache.org/thread/do5s8ro0ccz5d3o1q29ps8yx90mdofqx >> > > > > >> > > > > The release candidate: >> > > > > >> > > > > >> > > > > >> > > >> https://dist.apache.org/repos/dist/dev/incubator/pekko/CONNECTORS-1.0.1-RC1/ >> > > > > >> > > > > This release has been signed with a *recently updated* PGP key, >> > > available >> > > > > here: >> > > > > >> > > > > https://dist.apache.org/repos/dist/release/incubator/pekko/KEYS >> > > > > >> > > > > Release Notes: >> > > > > >> > > > > >> > > > > >> > > >> https://pekko.apache.org/docs/pekko-connectors/current/release-notes/index.html >> > > > > >> > > > > Git branch for the release: >> > > > > >> > > > > >> https://github.com/apache/incubator-pekko-connectors/tree/v1.0.1-RC1 >> > > > > Git commit ID: b4884fa64dac6f66e3cf758f0e42948f7202dfb9 >> > > > > >> > > > > Please download, verify, and test. >> > > > > >> > > > > We have also staged jars in the Apache Nexus Repository. These >> were >> > > > > built with the same code >> > > > > as appears in this Source Release Candidate. We would appreciate >> if >> > > > > users could test with these too. >> > > > > If anyone finds any serious problems with these jars, please also >> > > > > notify us on this thread. >> > > > > >> > > > > >> https://repository.apache.org/content/groups/staging/org/apache/pekko/ >> > > > > >> > > > > In sbt, you can add this resolver. >> > > > > >> > > > > resolvers += "Apache Pekko Staging" at >> > > > > "https://repository.apache.org/content/groups/staging"; >> > > > > >> > > > > >> > > > > The VOTE will pass if we have more positive votes than negative >> votes >> > > > > and there must be a minimum of 3 approvals from Pekko PPMC >> members. >> > > > > Anyone voting in favour of the release, could you please provide a >> > > > > list of the checks you have done? >> > > > > The vote will be left open until at least 15:00 UTC on 31 October >> 2023. >> > > > > >> > > > > [ ] +1 approve >> > > > > [ ] +0 no opinion >> > > > > [ ] -1 disapprove with the reason >> > > > > >> > > > > To learn more about Apache Pekko, please see >> https://pekko.apache.org/ >> > > > > >> > > > > Checklist for reference: >> > > > > >> > > > > [ ] Download links are valid. >> > > > > [ ] Checksums and signatures. >> > > > > [ ] LICENSE/NOTICE files exist >> > > > > [ ] No unexpected binary files >> > > > > [ ] Source files have ASF headers >> > > > > [ ] Can compile from source >> > > > > >> > > > > To compile from the source, please refer to: >> > > > > >> > > > > >> > > > > >> > > >> https://github.com/apache/incubator-pekko/blob/main/README.md#building-from-source >> > > > > >> > > > > Some notes about verifying downloads can be found at: >> > > > > >> > > > > https://pekko.apache.org/download.html#verifying-downloads >> > > > > >> > > > > >> > > > > Here is my +1. >> > > > > >> > > > > Thanks, >> > > > > >> > > > > PJ Fanning (Apache Pekko PPMC member) >> > > > > >> > > > > >> --------------------------------------------------------------------- >> > > > > To unsubscribe, e-mail: [email protected] >> > > > > For additional commands, e-mail: [email protected] >> > > > > >> > > > > >> > > > >> > > > -- >> > > > >> > > > Matthew de Detrich >> > > > >> > > > *Aiven Deutschland GmbH* >> > > > >> > > > Immanuelkirchstraße 26, 10405 Berlin >> > > > >> > > > Alexanderufer 3-7, 10117 Berlin >> > > > >> > > > Amtsgericht Charlottenburg, HRB 209739 B >> > > > >> > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > > > >> > > > *m:* +491603708037 >> > > > >> > > > *w:* aiven.io *e:* [email protected] >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: [email protected] >> > > For additional commands, e-mail: [email protected] >> > > >> > > >> > >> > -- >> > >> > Matthew de Detrich >> > >> > *Aiven Deutschland GmbH* >> > >> > Immanuelkirchstraße 26, 10405 Berlin >> > >> > Alexanderufer 3-7, 10117 Berlin >> > >> > Amtsgericht Charlottenburg, HRB 209739 B >> > >> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > >> > *m:* +491603708037 >> > >> > *w:* aiven.io *e:* [email protected] >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Alexanderufer 3-7, 10117 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* [email protected] > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Alexanderufer 3-7, 10117 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
