Thanks Justin. I will cancel this vote and look into the issue that you've raised.
On Mon, 30 Oct 2023 at 16:49, Justin Mclean <[email protected]> wrote: > > HI, > > > Sorry, but it’s -1 (binding) from me. The source contains code under the EPL > license, a category B license that can’t be included in a source release. [6] > Perhaps [4] and [5] are also under this license? > > I checked: > - incubating in the name > - hash and signature are fine > - LICENSE and NOTICE are fine. However, it would be nice to note the > copyright owner. > - No binary files > - Some files are midding headers [1][2][3][4] > - Can't compile - no obvious instructions are included, and the compile fails > with "Failed to derive version from git tags”. > > Kind Regards, > Justin > > 1. > ./csv-bench/src/main/scala/org/apache/pekko/stream/connectors/csv/scaladsl/CsvBench.scala > 2. > ./google-cloud-bigquery/src/main/boilerplate/org/apache/pekko/stream/connectors/googlecloud/bigquery/scaladsl/schema/ProductSchemasInstances.scala.template > 3. > ./google-cloud-bigquery/src/main/boilerplate/org/apache/pekko/stream/connectors/googlecloud/bigquery/scaladsl/spray/BigQueryProductFormatsInstances.scala.template > 4. > ./mqtt-streaming-bench/src/main/scala/org/apache/pekko/stream/connectors/mqtt/MqttPerf.scala > 5. > ./mqtt-streaming-bench/src/main/scala/org/apache/pekko/stream/connectors/mqtt/streaming/MqttPerf.scala > 6. > ./mqtt-streaming/src/main/scala/org/apache/pekko/stream/connectors/mqtt/streaming/impl/RequestState.scala > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
