Joe Schaefer wrote:
"Philippe M. Chiasson" <[EMAIL PROTECTED]> writes:
Forgot to mention I want to test this patch and look thru it carefully before it goes in.
Thanks Phillippe! Keep in mind I threw it together rather hastily, so if you still like it after testing,
I've tested it hapilly and it is both a simpler implementation and gets away with quite an annoying bug, so I'd like to see it integrated with a few tweaks.
I'll gladly clean it up a bit (sync the comments and a the missing #ifdef USE_ITHREADS).
Yes, a few notes on that patch:
- Watch lines > 72 charactres
- sv_magic(sv, Nullsv, PERL_MAGIC_ext, "APR::Pool", sizeof("APR::Pool"));
- Probably make it a macro since it's twice in the code
- "APR::Pool" should be in it's own #define
- #ifdef USE_ITHREADS where needed
- At least one test case for this (check my post
http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=109596770111457&w=2)-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
