Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14859660
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java ---
@@ -169,7 +170,7 @@ private boolean
hasImmutableIndexWithKeyValueColumns(TableRef tableRef) {
}
for (PTable index : tableRef.getTable().getIndexes()) {
for (PColumn column : index.getPKColumns()) {
- if (!IndexUtil.isDataPKColumn(column)) {
+ if (!IndexUtil.isDataPKColumn(column) &&
(index.getIndexType() != IndexType.LOCAL ||
!column.getName().toString().equals(MetaDataUtil.VIEW_INDEX_ID_COLUMN_NAME))) {
--- End diff --
Just move the check for the index being a local index outside of the loop
(and skip that index in that case). We should never match based on the column
name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
