[jira] [Commented] (PHOENIX-1705) implement ARRAY_APPEND built in function

[Samarth Jain (JIRA)]

    [ 
https://issues.apache.org/jira/browse/PHOENIX-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359498#comment-14359498
 ] 

Samarth Jain commented on PHOENIX-1705:
---------------------------------------

+1 to what James said. I didn't realize that baseType.coerceBytes() will simply 
return if 
{code}
if (this.isBytesComparableWith(actualType)) { // No coerce necessary
      if (actualModifier == expectedModifier) {
        return;
      }
}
{code}

So yes, there is no need of tracking isCastable. 

> implement ARRAY_APPEND built in function
> ----------------------------------------
>
>                 Key: PHOENIX-1705
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1705
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Dumindu Buddhika
>            Assignee: Dumindu Buddhika
>         Attachments: 
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch, 
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch, 
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)