[
https://issues.apache.org/jira/browse/PHOENIX-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375565#comment-14375565
]
ramkrishna.s.vasudevan commented on PHOENIX-1705:
-------------------------------------------------
Looks good to me. Very minor nits
{code}
+ @Override
+ public PDataType getDataType() {
+ return
PDataType.fromTypeId(children.get(0).getDataType().getSqlType());
+ }
{code}
Just return the baseType here.
In some spaces there are no white space before and after the operator
{code}
offset+offsetArrayPosition
{code}
Just add spaces before and after the operators for readability. Rest looks good
to me. [~giacomotaylor] Are you fine?
> implement ARRAY_APPEND built in function
> ----------------------------------------
>
> Key: PHOENIX-1705
> URL: https://issues.apache.org/jira/browse/PHOENIX-1705
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Dumindu Buddhika
> Assignee: Dumindu Buddhika
> Attachments:
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function1.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function2.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function3.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function4.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function5.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
