[
https://issues.apache.org/jira/browse/PHOENIX-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366000#comment-14366000
]
ASF GitHub Bot commented on PHOENIX-1712:
-----------------------------------------
Github user gabrielreid commented on the pull request:
https://github.com/apache/phoenix/pull/47#issuecomment-82582761
This code looks pretty good (with the exception of a few code-formatting
issues). I think that the test coverage should be extended a bit though, with
the following things being added:
* tests using both sort orders (ascending and descending)
* a test where a the input value is null
* a test where the search string isn't found to verify the return value in
that situation
* a test where the function is used in a filter (as this ensures that the
function is serialized/deserialized)
Specifically around the serialization/deserialization, there will be a
no-args constructor needed, as well as an init method to initialize the search
string. See the implementation of RegexpSplitFunction for an example of how
this is done.
> Implementing INSTR function
> ---------------------------
>
> Key: PHOENIX-1712
> URL: https://issues.apache.org/jira/browse/PHOENIX-1712
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Naveen Madhire
> Assignee: Naveen Madhire
> Priority: Minor
> Original Estimate: 40h
> Remaining Estimate: 40h
>
> This is sub-task to implement a custom INSTR function just like in Oracle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
